Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 3007543002: Add PeerConnectionObserver#onRemoveTrack to android sdk

Created:
1 year, 3 months ago by korniltsev
Modified:
1 year, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add PeerConnectionObserver#onRemoveTrack to android sdk Implement track modification observer with MediaStreamObserver BUG=5677

Patch Set 1 #

Total comments: 6

Patch Set 2 : review fix: public interface method with default empty implementation #

Patch Set 3 : review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -60 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/MediaStreamTrack.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/android/api/org/webrtc/PeerConnection.java View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/RtpReceiver.java View 1 2 1 chunk +10 lines, -3 lines 0 comments Download
M webrtc/sdk/android/instrumentationtests/src/org/webrtc/PeerConnectionTest.java View 1 2 7 chunks +39 lines, -15 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/peerconnectionobserver_jni.h View 1 2 5 chunks +23 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/pc/peerconnectionobserver_jni.cc View 1 2 7 chunks +184 lines, -39 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
korniltsev
previous attempt: https://codereview.webrtc.org/2990683002/
1 year, 3 months ago (2017-08-24 21:33:12 UTC) #3
Taylor Brandstetter
Note that this doesn't really fix https://bugs.chromium.org/p/webrtc/issues/detail?id=5677; that bug is about the Java MediaStream being ...
1 year, 3 months ago (2017-08-29 19:48:10 UTC) #4
korniltsev
onAddTrack is implemented with PeerConnectionObserver onRemoveTrack is implemented with MediaStreamObserver PeerConnectionObserver#onAddTrack/onRemoveTrack now accepts RtpReceiver as ...
1 year, 3 months ago (2017-08-30 21:47:47 UTC) #5
korniltsev
Should I do something else or is there something wrong with the CL? Btw, are ...
1 year, 3 months ago (2017-09-08 07:43:41 UTC) #6
Taylor Brandstetter
On 2017/09/08 07:43:41, korniltsev wrote: > Should I do something else or is there something ...
1 year, 3 months ago (2017-09-08 20:47:35 UTC) #7
Taylor Brandstetter
On 2017/09/08 20:47:35, Taylor Brandstetter wrote: > On 2017/09/08 07:43:41, korniltsev wrote: > > Should ...
1 year, 2 months ago (2017-09-18 17:28:33 UTC) #8
guptaromi2529
1 year, 2 months ago (2017-09-28 04:46:31 UTC) #9
On 2017/09/18 17:28:33, Taylor Brandstetter wrote:
> On 2017/09/08 20:47:35, Taylor Brandstetter wrote:
> > On 2017/09/08 07:43:41, korniltsev wrote:
> > > Should I do something else or is there something wrong with the CL?
> > 
> > Sorry, I've just been on vacation + sick so I'm behind on code reviews, but
I
> > still plan to review this.
> 
> This week I'm at an offsite in Stockholm, so I probably won't be able to
respond
> until next week. Again, my apologies.

http://kodidownloadz.com/kodi-17-4-apk-download/
http://kodidownloadz.com/install-genesis-on-kodi/

Powered by Google App Engine
This is Rietveld 408576698