telemetry/telemetry/internal/results/json_output_formatter_unittest.py - Issue 3007313002: Revert of Plumb trace canonicalUrl through TelemetryInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/results/json_output_formatter_unittest.py

Issue 3007313002: Revert of Plumb trace canonicalUrl through TelemetryInfo. (Closed)

Patch Set: Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/results/csv_pivot_table_output_formatter_unittest.py ('k') | telemetry/telemetry/internal/results/page_test_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/results/json_output_formatter_unittest.py

diff --git a/telemetry/telemetry/internal/results/json_output_formatter_unittest.py b/telemetry/telemetry/internal/results/json_output_formatter_unittest.py

index 6c3681374c08a54f40b5f796f49e0e4a4d6b7dd6..6a1c88507bb50083726df9fdedab8b669dd8ce27 100644

--- a/telemetry/telemetry/internal/results/json_output_formatter_unittest.py

+++ b/telemetry/telemetry/internal/results/json_output_formatter_unittest.py

@@ -87,11 +87,10 @@

results.WillRunPage(self._story_set[0])

v0 = trace.TraceValue(

results.current_page,

- trace_data.CreateTraceDataFromRawData([{'event': 'test'}]),

- file_path=os.path.join(tempdir, 'trace.html'))

+ trace_data.CreateTraceDataFromRawData([{'event': 'test'}]))

results.AddValue(v0)

results.DidRunPage(self._story_set[0])

- results._SerializeTracesToDirPath()

+ results._SerializeTracesToDirPath(tempdir)

d = json_output_formatter.ResultsAsDict(

results, self._formatter.benchmark_metadata)