Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: telemetry/telemetry/internal/results/json_output_formatter_unittest.py

Issue 3007313002: Revert of Plumb trace canonicalUrl through TelemetryInfo. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import json 4 import json
5 import os 5 import os
6 import shutil 6 import shutil
7 import StringIO 7 import StringIO
8 import tempfile 8 import tempfile
9 import unittest 9 import unittest
10 10
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 self.assertTrue(_HasPage(d['pages'], self._story_set[0])) 80 self.assertTrue(_HasPage(d['pages'], self._story_set[0]))
81 self.assertTrue(_HasValueNamed(d['per_page_values'], 'foo')) 81 self.assertTrue(_HasValueNamed(d['per_page_values'], 'foo'))
82 82
83 def testAsDictWithTraceValue(self): 83 def testAsDictWithTraceValue(self):
84 tempdir = tempfile.mkdtemp() 84 tempdir = tempfile.mkdtemp()
85 try: 85 try:
86 results = page_test_results.PageTestResults() 86 results = page_test_results.PageTestResults()
87 results.WillRunPage(self._story_set[0]) 87 results.WillRunPage(self._story_set[0])
88 v0 = trace.TraceValue( 88 v0 = trace.TraceValue(
89 results.current_page, 89 results.current_page,
90 trace_data.CreateTraceDataFromRawData([{'event': 'test'}]), 90 trace_data.CreateTraceDataFromRawData([{'event': 'test'}]))
91 file_path=os.path.join(tempdir, 'trace.html'))
92 results.AddValue(v0) 91 results.AddValue(v0)
93 results.DidRunPage(self._story_set[0]) 92 results.DidRunPage(self._story_set[0])
94 results._SerializeTracesToDirPath() 93 results._SerializeTracesToDirPath(tempdir)
95 d = json_output_formatter.ResultsAsDict( 94 d = json_output_formatter.ResultsAsDict(
96 results, self._formatter.benchmark_metadata) 95 results, self._formatter.benchmark_metadata)
97 96
98 self.assertTrue(_HasPage(d['pages'], self._story_set[0])) 97 self.assertTrue(_HasPage(d['pages'], self._story_set[0]))
99 self.assertTrue(_HasValueNamed(d['per_page_values'], 'trace')) 98 self.assertTrue(_HasValueNamed(d['per_page_values'], 'trace'))
100 self.assertEquals(len(d['files']), 1) 99 self.assertEquals(len(d['files']), 1)
101 output_trace_path = d['files'].values()[0] 100 output_trace_path = d['files'].values()[0]
102 self.assertTrue(output_trace_path.startswith(tempdir)) 101 self.assertTrue(output_trace_path.startswith(tempdir))
103 self.assertTrue(os.path.exists(output_trace_path)) 102 self.assertTrue(os.path.exists(output_trace_path))
104 finally: 103 finally:
(...skipping 25 matching lines...) Expand all
130 results = page_test_results.PageTestResults() 129 results = page_test_results.PageTestResults()
131 v = scalar.ScalarValue(None, 'baz', 'seconds', 5, 130 v = scalar.ScalarValue(None, 'baz', 'seconds', 5,
132 improvement_direction=improvement_direction.DOWN) 131 improvement_direction=improvement_direction.DOWN)
133 results.AddSummaryValue(v) 132 results.AddSummaryValue(v)
134 133
135 d = json_output_formatter.ResultsAsDict( 134 d = json_output_formatter.ResultsAsDict(
136 results, self._formatter.benchmark_metadata) 135 results, self._formatter.benchmark_metadata)
137 136
138 self.assertFalse(d['pages']) 137 self.assertFalse(d['pages'])
139 self.assertTrue(_HasValueNamed(d['summary_values'], 'baz')) 138 self.assertTrue(_HasValueNamed(d['summary_values'], 'baz'))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698