telemetry/telemetry/internal/results/csv_pivot_table_output_formatter_unittest.py - Issue 3007063002: Plumb trace canonicalUrl through TelemetryInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/results/csv_pivot_table_output_formatter_unittest.py

Issue 3007063002: Plumb trace canonicalUrl through TelemetryInfo. (Closed)

Patch Set: fix trace_unittest Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/results/csv_output_formatter_unittest.py ('k') | telemetry/telemetry/internal/results/json_output_formatter_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/results/csv_pivot_table_output_formatter_unittest.py

diff --git a/telemetry/telemetry/internal/results/csv_pivot_table_output_formatter_unittest.py b/telemetry/telemetry/internal/results/csv_pivot_table_output_formatter_unittest.py

index 2fe1a0f17c872e70db970c5c87f9a4fa6d3756d1..85f777fb887483a7cc7bc9cb838f4b4f882aaa9f 100644

--- a/telemetry/telemetry/internal/results/csv_pivot_table_output_formatter_unittest.py

+++ b/telemetry/telemetry/internal/results/csv_pivot_table_output_formatter_unittest.py

@@ -79,8 +79,10 @@ class CsvPivotTableOutputFormatterTest(unittest.TestCase):

def testMultiplePagesAndValues(self, cs_insert_mock):

cs_insert_mock.return_value = 'https://cloud_storage_url/foo'

trace_value = trace.TraceValue(

- None, trace_data.CreateTraceDataFromRawData('{"traceEvents": []}'))

- trace_value.UploadToCloud(bucket='foo')

+ None, trace_data.CreateTraceDataFromRawData('{"traceEvents": []}'),

+ remote_path='rp', upload_bucket='foo',

+ cloud_url='https://cloud_storage_url/foo')

+ trace_value.UploadToCloud()

self.SimulateBenchmarkRun([

(self._story_set[0], [

scalar.ScalarValue(