Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: telemetry/telemetry/internal/results/csv_output_formatter_unittest.py

Issue 3007063002: Plumb trace canonicalUrl through TelemetryInfo. (Closed)
Patch Set: fix trace_unittest Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | telemetry/telemetry/internal/results/csv_pivot_table_output_formatter_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/results/csv_output_formatter_unittest.py
diff --git a/telemetry/telemetry/internal/results/csv_output_formatter_unittest.py b/telemetry/telemetry/internal/results/csv_output_formatter_unittest.py
index 6faa09c58d5a954844726af1f8a8668fa0acfd22..d93395489e62eb6073babc9ae36893c6288e116d 100644
--- a/telemetry/telemetry/internal/results/csv_output_formatter_unittest.py
+++ b/telemetry/telemetry/internal/results/csv_output_formatter_unittest.py
@@ -82,8 +82,9 @@ class CsvOutputFormatterTest(unittest.TestCase):
def testMultiplePagesAndValues(self, cs_insert_mock):
cs_insert_mock.return_value = 'https://cloud_storage_url/foo'
trace_value = trace.TraceValue(
- None, trace_data.CreateTraceDataFromRawData('{"traceEvents": []}'))
- trace_value.UploadToCloud(bucket='foo')
+ None, trace_data.CreateTraceDataFromRawData('{"traceEvents": []}'),
+ remote_path='rp', upload_bucket='foo', cloud_url='http://google.com')
+ trace_value.UploadToCloud()
self.SimulateBenchmarkRun([
(self._story_set[0], [
scalar.ScalarValue(
« no previous file with comments | « no previous file | telemetry/telemetry/internal/results/csv_pivot_table_output_formatter_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698