Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
3006253002:
Avoid String.fromCharCode in building TraceStreams (Closed)
|
Created:
3 years, 3 months ago by chiniforooshan Modified:
3 years, 3 months ago Reviewers:
benjhayden CC:
catapult-reviews_chromium.org, ehmaldonado_chromium, tracing-review_chromium.org Target Ref:
refs/heads/master Project:
catapult Visibility:
Public. |
DescriptionAvoid String.fromCharCode in building TraceStreams
As discovered in catapult:#2051, String.fromCharCode uses too much
memory and it is better to use TextDecoder if possible.
BUG=chromium:731047
Review-Url: https://chromiumcodereview.appspot.com/3006253002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/cd2d1cccba7627d91a0c10ec6dec37ee6d5896d4
Patch Set 1 #
Messages
Total messages: 18 (13 generated)
chiniforooshan@chromium.org changed reviewers: + benjhayden@chromium.org
PTAL
CCing ehmaldonado@ since this may affect stream processing performance, too (catapult:#3654).
The CQ bit was checked by chiniforooshan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)
Description was changed from ========== Avoid String.fromCharCode in building TraceStreams As discovered in catapult:#2051, String.fromCharCode uses too much memory and it is better to use TextDecoder if possible. BUG=731047 ========== to ========== Avoid String.fromCharCode in building TraceStreams As discovered in catapult:#2051, String.fromCharCode uses too much memory and it is better to use TextDecoder if possible. BUG=chromium:731047 ==========
The CQ bit was checked by chiniforooshan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by chiniforooshan@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1504892479238350, "parent_rev":
"8e9a3287ddd2aeba259d1be8dd1ea71b56ed1089", "commit_rev":
"cd2d1cccba7627d91a0c10ec6dec37ee6d5896d4"}
Message was sent while issue was closed.
Description was changed from ========== Avoid String.fromCharCode in building TraceStreams As discovered in catapult:#2051, String.fromCharCode uses too much memory and it is better to use TextDecoder if possible. BUG=chromium:731047 ========== to ========== Avoid String.fromCharCode in building TraceStreams As discovered in catapult:#2051, String.fromCharCode uses too much memory and it is better to use TextDecoder if possible. BUG=chromium:731047 Review-Url: https://chromiumcodereview.appspot.com/3006253002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
