Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 3005313002: Reland Plumb trace canonicalUrl through TelemetryInfo. (Closed)

Created:
3 years, 3 months ago by benjhayden
Modified:
3 years, 3 months ago
Reviewers:
eakuefner, nednguyen, shatch
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Reland Plumb trace canonicalUrl through TelemetryInfo. Currently, trace canonical URLs are constructed after serializing the trace. This prevents Histogram results from containing the canonical URL. This CL constructs trace canonical URLs before serializing the trace so that Histograms can contain the canonical URL. http://www/~benjhayden/763375.html This CL was originally landed in https://codereview.chromium.org/3007063002 and reverted in https://chromiumcodereview.appspot.com/3007313002/ This depends on https://chromium-review.googlesource.com/c/chromium/src/+/658263 Next CLs: - plumb traceUrls through ChartJsonConverter https://codereview.chromium.org/3008223002 BUG=catapult:#2431,chromium:763375 Review-Url: https://chromiumcodereview.appspot.com/3005313002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/5f3e94e29a7b023d9cf4031e9f9fde9bc6e0f4e6

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -76 lines) Patch
M telemetry/telemetry/internal/results/csv_output_formatter_unittest.py View 1 chunk +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/results/csv_pivot_table_output_formatter_unittest.py View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M telemetry/telemetry/internal/results/json_output_formatter_unittest.py View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/results/page_test_results.py View 1 2 8 chunks +60 lines, -9 lines 0 comments Download
M telemetry/telemetry/internal/results/results_options.py View 1 chunk +2 lines, -1 line 0 comments Download
M telemetry/telemetry/internal/story_runner.py View 1 chunk +2 lines, -5 lines 0 comments Download
M telemetry/telemetry/value/trace.py View 5 chunks +15 lines, -23 lines 0 comments Download
M telemetry/telemetry/value/trace_unittest.py View 1 2 3 4 2 chunks +14 lines, -20 lines 0 comments Download
M telemetry/telemetry/web_perf/timeline_based_measurement.py View 3 chunks +13 lines, -3 lines 0 comments Download
M tracing/tracing/metrics/metric_map_function.html View 1 chunk +7 lines, -0 lines 0 comments Download
M tracing/tracing/metrics/metric_map_function_test.html View 1 chunk +17 lines, -0 lines 0 comments Download
M tracing/tracing/metrics/metric_runner.py View 2 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 26 (17 generated)
benjhayden
3 years, 3 months ago (2017-09-11 18:49:41 UTC) #8
eakuefner
lgtm
3 years, 3 months ago (2017-09-11 20:58:57 UTC) #10
shatch
lgtm
3 years, 3 months ago (2017-09-13 01:27:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3005313002/20001
3 years, 3 months ago (2017-09-13 04:57:25 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Android%20Tryserver/builds/5230)
3 years, 3 months ago (2017-09-13 05:13:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3005313002/60001
3 years, 3 months ago (2017-09-13 06:00:55 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Android%20Tryserver/builds/5232)
3 years, 3 months ago (2017-09-13 06:16:27 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3005313002/100001
3 years, 3 months ago (2017-09-13 20:47:10 UTC) #23
commit-bot: I haz the power
3 years, 3 months ago (2017-09-13 21:19:12 UTC) #26
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698