Issue 3002853002: [infra] Remove dependence on //third_party/gyp/pylib/gyp/win_tool.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3002853002: [infra] Remove dependence on //third_party/gyp/pylib/gyp/win_tool.py (Closed)

Created:
3 years, 4 months ago by zra

Modified:
3 years, 4 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

[infra] Remove dependence on //third_party/gyp/pylib/gyp/win_tool.py This CL removes another dependence on gyp by using/updating scripts that have the same function in the chromium build. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/48d99f550e1b2fbdb4ddc12e1b26f48bce2ce540

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+366 lines, -198 lines)			Patch
M	build/toolchain/win/BUILD.gn	View	1	7 chunks	+17 lines, -22 lines	0 comments	Download
D	build/toolchain/win/midl.gni	View		1 chunk	+0 lines, -113 lines	0 comments	Download
M	build/toolchain/win/setup_toolchain.py	View		3 chunks	+125 lines, -63 lines	0 comments	Download
A	build/toolchain/win/tool_wrapper.py	View		1 chunk	+224 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

zra

3 years, 4 months ago (2017-08-17 21:13:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
48d99f550e1b2fbdb4ddc12e1b26f48bce2ce540 (presubmit successful).