Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 3002833003: Adjust the column number where a StackOverflow error is reported. (Closed)

Created:
3 years, 4 months ago by sivachandra
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjust the column number where a StackOverflow error is reported. Before this change, the column number of the StackOverflow error was reported at the opening '(' of the function parameter list: ReturnType function(...) { ... } ^ This change moves it to the opening '{': ReturnType function(...) { ... } ^ In case of single statement functions with '=>', the location of the '=' is reported as the column number of the StackOverflow error. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/eeaeb6fbf654dc23a3ef96b89832cb748f638587

Patch Set 1 #

Patch Set 2 : fix typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -25 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 3 chunks +39 lines, -12 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder_test.cc View 11 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sivachandra
I am not sure if the change here is acceptable, but I could not come ...
3 years, 4 months ago (2017-08-17 16:43:01 UTC) #2
siva
lgtm Changing the column number to '{' and '=>' seems fine to me.
3 years, 4 months ago (2017-08-18 00:38:10 UTC) #4
sivachandra
3 years, 4 months ago (2017-08-21 09:09:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
eeaeb6fbf654dc23a3ef96b89832cb748f638587 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698