Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 3002833002: Try compiling android with c++14 using MB. (Closed)

Created:
3 years, 4 months ago by ehmaldonado_webrtc
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Try compiling android with c++14 using MB. BUG=

Patch Set 1 #

Patch Set 2 : Roll chromium_revision d323a482ee..c7cea15b71 (494468:495064) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M DEPS View 1 9 chunks +13 lines, -13 lines 0 comments Download
M tools_webrtc/mb/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ehmaldonado_webrtc
3 years, 4 months ago (2017-08-17 15:51:50 UTC) #2
ehmaldonado_webrtc
On 2017/08/17 15:51:50, ehmaldonado_webrtc wrote: This seems to work.
3 years, 4 months ago (2017-08-17 15:52:38 UTC) #3
oprypin_webrtc
On 2017/08/17 15:52:38, ehmaldonado_webrtc wrote: > On 2017/08/17 15:51:50, ehmaldonado_webrtc wrote: > > This seems ...
3 years, 4 months ago (2017-08-17 15:54:00 UTC) #4
kjellander_webrtc
On 2017/08/17 15:52:38, ehmaldonado_webrtc wrote: > On 2017/08/17 15:51:50, ehmaldonado_webrtc wrote: > > This seems ...
3 years, 4 months ago (2017-08-17 15:54:11 UTC) #5
ehmaldonado_webrtc
On 2017/08/17 15:54:11, kjellander_webrtc wrote: > On 2017/08/17 15:52:38, ehmaldonado_webrtc wrote: > > On 2017/08/17 ...
3 years, 4 months ago (2017-08-17 16:02:05 UTC) #6
kjellander_webrtc
3 years, 4 months ago (2017-08-17 16:50:16 UTC) #7
On 2017/08/17 16:02:05, ehmaldonado_webrtc wrote:
> On 2017/08/17 15:54:11, kjellander_webrtc wrote:
> > On 2017/08/17 15:52:38, ehmaldonado_webrtc wrote:
> > > On 2017/08/17 15:51:50, ehmaldonado_webrtc wrote:
> > > 
> > > This seems to work.
> > 
> > ok, but we really must try to avoid this as much as possible as we'd have to
> > communicate it to everyone, send PSA, update http://webrtc.org etc
> > Is there no way to do this in GN only?
> 
> Maybe there is, but I don't know how.
> 
> > It's nice that bots can pass. But as I understand it, normal local Android
> > builds will fail because they are not affected by this.
> 
> That's true.

Yeah, we should probably look into if we can quickly change to force C++14
instead.

Powered by Google App Engine
This is Rietveld 408576698