Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 3002723002: Trace viewer: move mouse mode selector into top controls bar. (Closed)

Created:
2 years, 3 months ago by benjhayden
Modified:
2 years, 1 month ago
Reviewers:
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Trace viewer: move mouse mode selector into top controls bar. BEFORE PUBLISHING: - shift, control temporary modes - move buttons to left controls? Currently, the mouse-mode-selector is a complex dom-module with many responsibilities. It is used in a few places: timeline-track-view, quad-stack-view, display-item-debugger, picture-debugger. This CL removes the mouse-mode-selector from timeline-track-view, and adds 4 mouse-mode-icons to timeline-view, which control timeline-track-view.mouseMode. http://i.imgur.com/eai9QzUh.png http://www/~benjhayden/3002723002.html BUG=catapult:#868

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -110 lines) Patch
M tracing/tracing/ui/timeline_track_view.html View 8 chunks +68 lines, -110 lines 0 comments Download
M tracing/tracing/ui/timeline_view.html View 6 chunks +64 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (14 generated)
benjhayden
Patchset #1 (id:1) has been deleted
2 years, 2 months ago (2017-08-18 05:59:59 UTC) #1
benjhayden
Patchset #1 (id:20001) has been deleted
2 years, 2 months ago (2017-08-18 06:00:03 UTC) #2
benjhayden
Patchset #1 (id:40001) has been deleted
2 years, 2 months ago (2017-08-18 06:00:08 UTC) #3
benjhayden
Patchset #1 (id:60001) has been deleted
2 years, 2 months ago (2017-08-18 06:00:13 UTC) #4
benjhayden
Patchset #1 (id:80001) has been deleted
2 years, 2 months ago (2017-08-18 06:07:06 UTC) #5
benjhayden
Description was changed from ========== Trace viewer: move mouse mode selector into top controls bar. ...
2 years, 2 months ago (2017-08-18 06:16:16 UTC) #6
benjhayden
Description was changed from ========== Trace viewer: move mouse mode selector into top controls bar. ...
2 years, 2 months ago (2017-08-18 06:16:26 UTC) #7
benjhayden
Description was changed from ========== Trace viewer: move mouse mode selector into top controls bar. ...
2 years, 2 months ago (2017-08-18 06:16:33 UTC) #8
benjhayden
Description was changed from ========== Trace viewer: move mouse mode selector into top controls bar. ...
2 years, 2 months ago (2017-08-18 06:16:41 UTC) #9
benjhayden
Description was changed from ========== Trace viewer: move mouse mode selector into top controls bar. ...
2 years, 2 months ago (2017-08-21 23:42:07 UTC) #10
benjhayden
Description was changed from ========== Trace viewer: move mouse mode selector into top controls bar. ...
2 years, 2 months ago (2017-08-22 15:52:01 UTC) #11
benjhayden
Description was changed from ========== Trace viewer: move mouse mode selector into top controls bar. ...
2 years, 2 months ago (2017-08-24 04:42:37 UTC) #12
benjhayden
Description was changed from ========== Trace viewer: move mouse mode selector into top controls bar. ...
2 years, 2 months ago (2017-08-24 04:47:04 UTC) #13
benjhayden
2 years, 2 months ago (2017-08-24 04:47:20 UTC) #14
Description was changed from

==========
Trace viewer: move mouse mode selector into top controls bar.

BEFORE PUBLISHING: shift, control temporary modes

Currently, the mouse-mode-selector is a complex dom-module with many
responsibilities. It is used in a few places: timeline-track-view,
quad-stack-view,
display-item-debugger, picture-debugger.

This CL removes the mouse-mode-selector from timeline-track-view, and adds 4
mouse-mode-icons to timeline-view, which control timeline-track-view.mouseMode.

http://i.imgur.com/eai9QzUh.png

http://www/~benjhayden/3002723002.html

BUG=catapult:#868
==========

to

==========
Trace viewer: move mouse mode selector into top controls bar.

BEFORE PUBLISHING:
- shift, control temporary modes
- move buttons to left controls?

Currently, the mouse-mode-selector is a complex dom-module with many
responsibilities. It is used in a few places: timeline-track-view,
quad-stack-view,
display-item-debugger, picture-debugger.

This CL removes the mouse-mode-selector from timeline-track-view, and adds 4
mouse-mode-icons to timeline-view, which control timeline-track-view.mouseMode.

http://i.imgur.com/eai9QzUh.png

http://www/~benjhayden/3002723002.html

BUG=catapult:#868
==========

Powered by Google App Engine
This is Rietveld 408576698