Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: tracing/tracing/importer/find_input_expectations.html

Issue 3001273002: Hide UserModelBuilder warnings. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/importer/find_input_expectations.html
diff --git a/tracing/tracing/importer/find_input_expectations.html b/tracing/tracing/importer/find_input_expectations.html
index 080ce230f2763e960c487f8d46d6385b2ee680a1..986b5d37a04457da8891d5530b871048fc520760 100644
--- a/tracing/tracing/importer/find_input_expectations.html
+++ b/tracing/tracing/importer/find_input_expectations.html
@@ -548,8 +548,8 @@ tr.exportTo('tr.importer', function() {
if (currentPE) {
warn({
type: 'UserModelBuilder',
- message: 'Please file a bug with this trace: FlingStart',
- showToUser: true
+ message: 'Unexpected FlingStart',
+ showToUser: false,
});
currentPE.pushEvent(event);
} else {
@@ -730,8 +730,8 @@ tr.exportTo('tr.importer', function() {
if (!currentPE) {
warn({
type: 'UserModelBuilder',
- message: 'Please file a bug with this trace: ScrollEnd',
- showToUser: true
+ message: 'Unexpected ScrollEnd',
+ showToUser: false,
});
const pe = new ProtoExpectation(ProtoExpectation.IGNORED_TYPE);
pe.pushEvent(event);
@@ -1226,9 +1226,8 @@ tr.exportTo('tr.importer', function() {
(event.title !== tr.model.helpers.IMPL_RENDERING_STATS)) {
warn({
type: 'UserModelBuilder',
- message: 'Please file a bug with this trace: ' +
- `double-handled event: ${event.typeName} @ ${event.start}`,
- showToUser: true
+ message: `double-handled event: ${event.typeName} @ ${event.start}`,
+ showToUser: false,
});
return;
}
@@ -1240,9 +1239,8 @@ tr.exportTo('tr.importer', function() {
if (handledEvents.indexOf(event) < 0) {
warn({
type: 'UserModelBuilder',
- message: 'Please file a bug with this trace: ' +
- `double-handled event: ${event.typeName} @ ${event.start}`,
- showToUser: true
+ message: `double-handled event: ${event.typeName} @ ${event.start}`,
+ showToUser: false,
});
}
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698