Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 3001273002: Hide UserModelBuilder warnings. (Closed)

Created:
3 years, 4 months ago by benjhayden
Modified:
3 years, 4 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Hide UserModelBuilder warnings. Currently, the UserModelBuilder validates its output and displays warnings when an unexpected condition arises such as double-handled event. These warnings were vanishingly rare when UMB was first written, but are becoming increasingly common, possibly due to changes in Chromium's input latency tracing system. BUG=catapult:#3788 Review-Url: https://codereview.chromium.org/3001273002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/fe2f064dd4117da93ce92a8a85953620e0ef6e11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M tracing/tracing/importer/find_input_expectations.html View 4 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
benjhayden
PTAL
3 years, 4 months ago (2017-08-20 18:00:02 UTC) #2
eakuefner
lgtm
3 years, 4 months ago (2017-08-20 22:05:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3001273002/1
3 years, 4 months ago (2017-08-21 05:06:48 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-21 05:34:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698