Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 2999863002: Results.html: record maximum Histogram.numValues in google analytics.

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 days, 22 hours ago by benjhayden
Modified:
4 days, 22 hours ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Results.html: record maximum Histogram.numValues in google analytics. This CL records an instant event 'HistogramParameterCollector.maxSampleCount' containing the maximum numValues from the raw Histograms that were produced directly by metrics, before the Histograms are merged. We know that this number is always 1 for some metrics. If this number is always 1 across *all* metrics, then we may want to simplify the metrics API from Histograms to Scalars. In that case, Histograms would still be necessary as an implementation detail for results.html and the dashboard Histogram Pipeline, but the metrics API could be simplified. If this number is not always 1, then it will be easier to explain why the metrics API requires Histograms instead of the seemingly simpler Scalars.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tracing/tracing/value/histogram_parameter_collector.html View 3 chunks +6 lines, -0 lines 0 comments Download
M tracing/tracing/value/ui/timings.md View 1 chunk +2 lines, -0 lines 0 comments Download
Trybot results: Sign in to try more bots
Commit queue not available (can’t edit this change).

Messages

Total messages: 3 (2 generated)
benjhayden
4 days, 22 hours ago (2017-08-12 20:25:36 UTC) #3
PTAL
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b