DescriptionResults.html: record maximum Histogram.numValues in google analytics.
This CL records an instant event 'HistogramParameterCollector.maxSampleCount'
containing the maximum numValues from the raw Histograms that were produced directly
by metrics, before the Histograms are merged.
We know that this number is always 1 for some metrics.
If this number is always 1 across *all* metrics, then we may want to simplify the
metrics API from Histograms to Scalars. In that case, Histograms would still be
necessary as an implementation detail for results.html and the dashboard Histogram
Pipeline, but the metrics API could be simplified.
If this number is not always 1, then it will be easier to explain why the metrics
API requires Histograms instead of the seemingly simpler Scalars.
Review-Url: https://codereview.chromium.org/2999863002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d768f57acb8966c50c10edfe9050c1caa6a2003f
Patch Set 1 #Patch Set 2 : fix vinn tests #
Messages
Total messages: 15 (8 generated)
|