Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2998903002: Add a test that requires adding an import (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 days, 3 hours ago by Brian Wilkerson
Modified:
4 days, 3 hours ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a test that requires adding an import Committed: https://github.com/dart-lang/sdk/commit/31887d6e428c0b830b35aeec4fc2ffb6ca196062

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +46 lines, -0 lines 2 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
Here's the test I wrote based on your report. I think it's worth adding because ...
5 days, 3 hours ago (2017-08-12 15:19:57 UTC) #2
scheglov
https://codereview.chromium.org/2998903002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart File pkg/analysis_server/test/services/correction/fix_test.dart (right): https://codereview.chromium.org/2998903002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart#newcode2512 pkg/analysis_server/test/services/correction/fix_test.dart:2512: addPackageSource('analyzer', 'file_system/physical_file_system.dart', ''' I would prefer to use sanitized ...
4 days, 20 hours ago (2017-08-12 22:28:32 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2998903002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart File pkg/analysis_server/test/services/correction/fix_test.dart (right): https://codereview.chromium.org/2998903002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart#newcode2512 pkg/analysis_server/test/services/correction/fix_test.dart:2512: addPackageSource('analyzer', 'file_system/physical_file_system.dart', ''' Done
4 days, 3 hours ago (2017-08-13 15:33:34 UTC) #4
Brian Wilkerson
4 days, 3 hours ago (2017-08-13 15:33:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
31887d6e428c0b830b35aeec4fc2ffb6ca196062 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b