Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3360)

Unified Diff: dashboard/dashboard/static/memory_related_names.html

Issue 2993773002: Dashboard charts: display sparklines of related timeseries in a tab strip. (Closed)
Patch Set: fix warnings[].value Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dashboard/dashboard/static/group_alerts.html ('k') | dashboard/dashboard/static/related_timeseries.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/static/memory_related_names.html
diff --git a/dashboard/dashboard/static/memory_related_names.html b/dashboard/dashboard/static/memory_related_names.html
index 33969998fd764b930b196a84a41d3c5b7af2c4f8..598f8359024361c15a45a428accf4b7883b5abe7 100644
--- a/dashboard/dashboard/static/memory_related_names.html
+++ b/dashboard/dashboard/static/memory_related_names.html
@@ -102,16 +102,17 @@ tr.exportTo('d', function() {
}
/* eslint-enable max-len */
- const MEMORY_RELATED_NAMES = new Map();
+ const MEMORY_PROCESS_RELATED_NAMES = new Map();
+ const MEMORY_COMPONENT_RELATED_NAMES = new Map();
const ALL_PROCESSES = 'all_processes';
const REPORTED_BY_CHROME = 'reported_by_chrome';
for (const name of MEMORY_NAMES) {
- let relatedNames = MEMORY_RELATED_NAMES.get(name);
- if (relatedNames === undefined) {
- relatedNames = new Set();
- MEMORY_RELATED_NAMES.set(name, relatedNames);
+ let processRelatedNames = MEMORY_PROCESS_RELATED_NAMES.get(name);
+ if (processRelatedNames === undefined) {
+ processRelatedNames = new Set();
+ MEMORY_PROCESS_RELATED_NAMES.set(name, processRelatedNames);
}
// Each 'all_processes' name is related to all ${process} variants of that
@@ -122,7 +123,7 @@ tr.exportTo('d', function() {
const suffix = name.slice(index + ALL_PROCESSES.length);
for (const other of MEMORY_NAMES) {
if (other.includes(suffix)) {
- relatedNames.add(other);
+ processRelatedNames.add(other);
}
}
}
@@ -134,15 +135,16 @@ tr.exportTo('d', function() {
const prefix = parts.slice(0, end).join(':');
const suffix = parts[parts.length - 1];
const sansComponent = `${prefix}:${suffix}`;
- if (!MEMORY_RELATED_NAMES.has(sansComponent)) {
- MEMORY_RELATED_NAMES.set(sansComponent, new Set());
+ if (!MEMORY_COMPONENT_RELATED_NAMES.has(sansComponent)) {
+ MEMORY_COMPONENT_RELATED_NAMES.set(sansComponent, new Set());
}
- MEMORY_RELATED_NAMES.get(sansComponent).add(name);
+ MEMORY_COMPONENT_RELATED_NAMES.get(sansComponent).add(name);
}
}
return {
- MEMORY_RELATED_NAMES,
+ MEMORY_PROCESS_RELATED_NAMES,
+ MEMORY_COMPONENT_RELATED_NAMES,
};
});
</script>
« no previous file with comments | « dashboard/dashboard/static/group_alerts.html ('k') | dashboard/dashboard/static/related_timeseries.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698