Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: dashboard/dashboard/static/group_alerts.html

Issue 2993773002: Dashboard charts: display sparklines of related timeseries in a tab strip. (Closed)
Patch Set: fix warnings[].value Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dashboard/dashboard/graph_json.py ('k') | dashboard/dashboard/static/memory_related_names.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/static/group_alerts.html
diff --git a/dashboard/dashboard/static/group_alerts.html b/dashboard/dashboard/static/group_alerts.html
index 38f1210a0f2ad92c4c5373f33bc26a98ebe54187..71573fe5adbdfaf27331f3e077eb738d593e1755 100644
--- a/dashboard/dashboard/static/group_alerts.html
+++ b/dashboard/dashboard/static/group_alerts.html
@@ -69,7 +69,17 @@ tr.exportTo('d', function() {
const groups = [];
for (const alert of alerts) {
alert.measurementName = alert.test.split('/')[0];
- alert.relatedNames = d.MEMORY_RELATED_NAMES.get(alert.measurementName);
+ if (d.MEMORY_PROCESS_RELATED_NAMES.has(alert.measurementName)) {
+ alert.relatedNames = d.MEMORY_PROCESS_RELATED_NAMES.get(
+ alert.measurementName);
+ }
+ if (d.MEMORY_COMPONENT_RELATED_NAMES.has(alert.measurementName)) {
+ alert.relatedNames = new Set(alert.relatedNames);
+ for (const name of d.MEMORY_COMPONENT_RELATED_NAMES.get(
+ alert.measurementName)) {
+ alert.relatedNames.add(name);
+ }
+ }
let merged = false;
for (const group of groups) {
« no previous file with comments | « dashboard/dashboard/graph_json.py ('k') | dashboard/dashboard/static/memory_related_names.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698