|
|
DescriptionFixed errors related to bad-continuation
Fixed pylint errors in:
telemetry/telemetry/internal/browser/browser_unittest.py
telemetry/telemetry/internal/image_processing/image_util_numpy_impl.py
telemetry/telemetry/internal/platform/cros_platform_backend_unittest.py
telemetry/telemetry/internal/platform/device_finder.py
Part 11
BUG=catapult:#3604
Review-Url: https://codereview.chromium.org/2988553002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/fc0d6193dd7ae707f7c16130713cf5d688073be1
Patch Set 1 #Patch Set 2 : Fixed additional errors #Patch Set 3 : Removed pylintrc changes #Patch Set 4 : Fix additional errors #
Messages
Total messages: 43 (37 generated)
The CQ bit was checked by loloangela@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)
The CQ bit was checked by loloangela@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)
The CQ bit was checked by loloangela@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)
The CQ bit was checked by loloangela@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)
The CQ bit was checked by loloangela@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)
The CQ bit was checked by loloangela@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)
The CQ bit was checked by loloangela@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)
The CQ bit was checked by loloangela@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Android Tryserver on master.tryserver.client.catapult (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
loloangela@google.com changed reviewers: + ashleymarie@google.com, nednguyen@google.com
Hey, Fixed additional errors related to the bad-continuation param. Please review. - Lori
On 2017/07/24 19:57:27, Lo-Lo wrote: > Hey, > > Fixed additional errors related to the bad-continuation param. > Please review. > > - Lori lgtm
On 2017/07/24 20:00:23, ashleymarie1 wrote: > On 2017/07/24 19:57:27, Lo-Lo wrote: > > Hey, > > > > Fixed additional errors related to the bad-continuation param. > > Please review. > > > > - Lori > > lgtm lgtm Can you add Part 11 to the title for consistency?
Description was changed from ========== Fixed errors related to bad-continuation Fixed pylint errors in: telemetry/telemetry/internal/browser/browser_unittest.py telemetry/telemetry/internal/image_processing/image_util_numpy_impl.py telemetry/telemetry/internal/platform/cros_platform_backend_unittest.py telemetry/telemetry/internal/platform/device_finder.py Part 11 BUG=catapult:#3604 ========== to ========== Fixed errors related to bad-continuation Fixed pylint errors in: telemetry/telemetry/internal/browser/browser_unittest.py telemetry/telemetry/internal/image_processing/image_util_numpy_impl.py telemetry/telemetry/internal/platform/cros_platform_backend_unittest.py telemetry/telemetry/internal/platform/device_finder.py Part 11 BUG=catapult:#3604 ==========
On 2017/07/24 21:37:52, nednguyen wrote: > On 2017/07/24 20:00:23, ashleymarie1 wrote: > > On 2017/07/24 19:57:27, Lo-Lo wrote: > > > Hey, > > > > > > Fixed additional errors related to the bad-continuation param. > > > Please review. > > > > > > - Lori > > > > lgtm > > lgtm > > Can you add Part 11 to the title for consistency? I got it
The CQ bit was checked by loloangela@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1500932596699700, "parent_rev": "9ccdbee1c298b557f6a02e00cc3a254e6fd24312", "commit_rev": "fc0d6193dd7ae707f7c16130713cf5d688073be1"}
Message was sent while issue was closed.
Description was changed from ========== Fixed errors related to bad-continuation Fixed pylint errors in: telemetry/telemetry/internal/browser/browser_unittest.py telemetry/telemetry/internal/image_processing/image_util_numpy_impl.py telemetry/telemetry/internal/platform/cros_platform_backend_unittest.py telemetry/telemetry/internal/platform/device_finder.py Part 11 BUG=catapult:#3604 ========== to ========== Fixed errors related to bad-continuation Fixed pylint errors in: telemetry/telemetry/internal/browser/browser_unittest.py telemetry/telemetry/internal/image_processing/image_util_numpy_impl.py telemetry/telemetry/internal/platform/cros_platform_backend_unittest.py telemetry/telemetry/internal/platform/device_finder.py Part 11 BUG=catapult:#3604 Review-Url: https://codereview.chromium.org/2988553002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |