Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: telemetry/telemetry/internal/platform/android_platform_backend.py

Issue 2982743002: webrtc: Fix missing port forwarding on CrOS (Closed)
Patch Set: webrtc: Fix missing port forwarding on CrOS and android Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/platform/android_platform_backend.py
diff --git a/telemetry/telemetry/internal/platform/android_platform_backend.py b/telemetry/telemetry/internal/platform/android_platform_backend.py
index c01561ffacda693d3a0af0fe4b56a54a9cad8502..987466f2dc9bd908c5db0907d7d60ca2176197da 100644
--- a/telemetry/telemetry/internal/platform/android_platform_backend.py
+++ b/telemetry/telemetry/internal/platform/android_platform_backend.py
@@ -153,6 +153,15 @@ class AndroidPlatformBackend(
def GetRemotePort(self, port):
return forwarder.Forwarder.DevicePortForHostPort(port) or 0
+ def CreatePortForwarder(self, port_pair, use_remote_port_forwarding):
+ # use_remote_port_forwarding is ignored as it is always true for
+ # Android device.
+ return self.forwarder_factory.Create(port_pair)
+
+ def IsDeviceRemote(self):
+ # Android device is connected via adb which is on remote.
+ return True
+
def IsDisplayTracingSupported(self):
return bool(self.GetOSVersionName() >= 'J')

Powered by Google App Engine
This is Rietveld 408576698