Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: telemetry/telemetry/internal/platform/platform_backend.py

Issue 2982743002: webrtc: Fix missing port forwarding on CrOS (Closed)
Patch Set: webrtc: Fix missing port forwarding on CrOS and android Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/internal/platform/cros_platform_backend.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/platform/platform_backend.py
diff --git a/telemetry/telemetry/internal/platform/platform_backend.py b/telemetry/telemetry/internal/platform/platform_backend.py
index d099940fc7853de49911aa7d997253cb492eb05a..f836be4f67562dbe8a28cb3b57f6f4c829408682 100644
--- a/telemetry/telemetry/internal/platform/platform_backend.py
+++ b/telemetry/telemetry/internal/platform/platform_backend.py
@@ -109,6 +109,20 @@ class PlatformBackend(object):
self._running_browser_backends.discard(browser_backend)
+ def CreatePortForwarder(self, port_pair, use_remote_port_forwarding):
+ """Use forwarder_factory to create a port forwarder."""
+ raise NotImplementedError()
+
+ def IsDeviceRemote(self):
nednguyen 2017/07/21 14:30:00 s/IsDeviceRemote/IsRemoteDevice
+ """Check if target browser is on remote device.
nednguyen 2017/07/21 14:30:00 The platform concept in Telemetry is agnostic abou
+
+ Returns True if device is on remote, i.e. android
+ device connected via adb or running a test with
+ remote option specifying the ip address of a cros device.
+ Return False for other platforms.
+ """
+ return False
+
def IsDisplayTracingSupported(self):
return False
« no previous file with comments | « telemetry/telemetry/internal/platform/cros_platform_backend.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698