Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 2981043002: Add a task queue task router to reduce amount of boilerplate.

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 1 day ago by Vadim Sh.
Modified:
5 days, 16 hours ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Add a task queue task router to reduce amount of boilerplate. R=tandrii@chromium.org BUG=

Patch Set 1 : tq-helper #

Total comments: 2

Patch Set 2 : add named tasks, remove globals #

Patch Set 3 : more features that will be needed later #

Patch Set 4 : bug #

Patch Set 5 : more bugs #

Patch Set 6 : respect rpc limits #

Patch Set 7 : comment nit #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+580 lines, -35 lines) Patch
M scheduler/appengine/engine/cron/demo/main.go View 1 2 6 chunks +25 lines, -35 lines 0 comments Download
A scheduler/appengine/engine/internal/gen.go View 1 chunk +18 lines, -0 lines 0 comments Download
A scheduler/appengine/engine/internal/tq_tasks.proto View 1 chunk +29 lines, -0 lines 0 comments Download
A scheduler/appengine/engine/internal/tq_tasks.pb.go View 1 chunk +94 lines, -0 lines 0 comments Download
A scheduler/appengine/engine/tq/tq.go View 1 2 3 4 5 6 1 chunk +414 lines, -0 lines 5 comments Download
Trybot results: Sign in to try more bots
Commit queue not available (can’t edit this change).

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
Vadim Sh.
I expect new engine implementation will be using more different task queue tasks. This CL ...
1 week, 1 day ago (2017-07-15 01:16:29 UTC) #1
tandrii(chromium)
5 days, 16 hours ago (2017-07-17 09:54:30 UTC) #2
sgtm

https://codereview.chromium.org/2981043002/diff/120001/scheduler/appengine/en...
File scheduler/appengine/engine/tq/tq.go (right):

https://codereview.chromium.org/2981043002/diff/120001/scheduler/appengine/en...
scheduler/appengine/engine/tq/tq.go:15: // Package tq implements simple routing
layer for task queue tasks.
once this is known to work (ie with tests :P), perhaps this is worth upstreaming
to top-level AE lib in luci-go, or maybe even luci/gae?

https://codereview.chromium.org/2981043002/diff/120001/scheduler/appengine/en...
scheduler/appengine/engine/tq/tq.go:149: // It means, add some later time in
some other GAE process, the callback
s/add/at

https://codereview.chromium.org/2981043002/diff/120001/scheduler/appengine/en...
scheduler/appengine/engine/tq/tq.go:211: err := <-errs
for below lines: this really asks for
MultiError.AppendRecursively(from, filter func(err error) error)

https://codereview.chromium.org/2981043002/diff/120001/scheduler/appengine/en...
scheduler/appengine/engine/tq/tq.go:212: if merr, yep :=
err.(errors.MultiError); yep {
yep :)

https://codereview.chromium.org/2981043002/diff/120001/scheduler/appengine/en...
scheduler/appengine/engine/tq/tq.go:361: httpReply(c, false, 200, "Fatal error:
%s", err) // return 200 to stop retries
so, are you saying that all our transient errors are correctly tagged as such?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973