Implement OscillatorNode.type= for Dartium.

Implement OscillatorNode.type= for Dartium.

BUG=http://dartbug.com/11984
R=vsm@google.com

Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1464

[rmacnak, 2013-10-18 23:20:59]

The discussion on the bug notes we have integer constants defined but the getter
and setter are typed for strings. The getter (which is generated?) already works
and answers strings and the integer constants have @deprecated annotations, so I
implemented the setter to take strings. V8 accepts either strings or integers.

Where do we put tests for this?

[siva, 2013-10-19 00:03:48]

Vijay can tell us if the Dart API can be restricted to just strings.

I would add the test case into dart/tests/html
I already see some audio* tests in that directory.

https://codereview.chromium.org/29783004/diff/1/Source/bindings/dart/custom/D...
File Source/bindings/dart/custom/DartOscillatorNodeCustom.cpp (right):

https://codereview.chromium.org/29783004/diff/1/Source/bindings/dart/custom/D...
Source/bindings/dart/custom/DartOscillatorNodeCustom.cpp:46: String type =
DartUtilities::dartToString(Dart_GetNativeArgument(args, 1), exception);
you could use DartUtilities::dartToString(args, 1, exception) here.

[rmacnak, 2013-10-21 23:44:46]

Counterpart is
https://chromiumcodereview.appspot.com/28973003/

https://chromiumcodereview.appspot.com/29783004/diff/1/Source/bindings/dart/c...
File Source/bindings/dart/custom/DartOscillatorNodeCustom.cpp (right):

https://chromiumcodereview.appspot.com/29783004/diff/1/Source/bindings/dart/c...
Source/bindings/dart/custom/DartOscillatorNodeCustom.cpp:46: String type =
DartUtilities::dartToString(Dart_GetNativeArgument(args, 1), exception);
On 2013/10/19 00:03:48, siva wrote:
> you could use DartUtilities::dartToString(args, 1, exception) here.

Done.

[vsm, 2013-10-22 00:03:44]

lgtm

Just chatted with Pete: the spec has moved from int to String.  It's fine to
enforce the latter.  The constants are deprecated and will be removed.

Note, this API is experimental (in chrome), and we may see further churn.

[rmacnak, 2013-10-23 00:09:18]

Committed patchset #7 manually as r1464 (presubmit successful).