Issue 2978263002: [inspector_protocol] Fix building with non-ASCII paths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Chromium Code Reviews

Issue 2978263002: [inspector_protocol] Fix building with non-ASCII paths

Created:
3 years, 5 months ago by Anna Henningsen

Modified:
3 years, 5 months ago

Reviewers:

CC:
chromium-reviews, devtools-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
inspector_protocol

Visibility:
Public.

More Reviews

Description

[inspector_protocol] Fix building with non-ASCII paths The Python code internally treats path as unicode strings, but the command line options are read as byte strings. Mixing these up does not work properly, so decode the CLI arguments after parsing. (This was noticed because it makes the Node.js build fail under paths containing non-ASCII characters.) BUG=

Patch Set 1 #

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	CodeGenerator.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download