Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2977493002: When a track is added/removed directly to MediaStream notify observer->OnRenegotionNeeded (Closed)

Created:
3 years, 5 months ago by korniltsev
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

When a track is added/removed directly to MediaStream notify observer->OnRenegotionNeeded There is an inconsistency in behavior of PeerConnection. When I remove track from PeerConnection observer->OnRenegotiationNeeded is called, however if I remove track from MediaStream then there is no notification to renegotiate. This patch adds missing OnRenegotiationNeeded calls. BUG=webrtc:7966 Review-Url: https://codereview.webrtc.org/2977493002 Cr-Commit-Position: refs/heads/master@{#19125} Committed: https://chromium.googlesource.com/external/webrtc/+/ec390b5dfbadb9972e4fafa36226d1724c6c2204

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added review comments #

Patch Set 3 : Fix tests. Apply patch. #

Patch Set 4 : When removing stream, do not remove tracks if pc is closed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -76 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/pc/peerconnection.h View 1 2 1 chunk +9 lines, -5 lines 0 comments Download
M webrtc/pc/peerconnection.cc View 1 2 3 6 chunks +100 lines, -71 lines 0 comments Download
M webrtc/pc/peerconnectioninterface_unittest.cc View 1 3 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
korniltsev
3 years, 5 months ago (2017-07-09 14:53:47 UTC) #3
Taylor Brandstetter
lgtm with nit (would like a brief comment describing the test). I also added a ...
3 years, 5 months ago (2017-07-10 21:40:30 UTC) #5
korniltsev
https://codereview.webrtc.org/2977493002/diff/1/webrtc/pc/peerconnectioninterface_unittest.cc File webrtc/pc/peerconnectioninterface_unittest.cc (right): https://codereview.webrtc.org/2977493002/diff/1/webrtc/pc/peerconnectioninterface_unittest.cc#newcode3705 webrtc/pc/peerconnectioninterface_unittest.cc:3705: On 2017/07/10 21:40:30, Taylor Brandstetter wrote: > nit: Can ...
3 years, 5 months ago (2017-07-12 06:51:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2977493002/20001
3 years, 5 months ago (2017-07-12 16:44:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/19959) android_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 5 months ago (2017-07-12 16:59:06 UTC) #11
Taylor Brandstetter
The Android test is failing because OnRenegotiationNeeded is being called more times than expected. I ...
3 years, 5 months ago (2017-07-12 20:30:44 UTC) #12
korniltsev
Hi. Sorry for late response. I've applied your patch with one change. When we remove ...
3 years, 5 months ago (2017-07-22 23:13:35 UTC) #13
Taylor Brandstetter
I'd prefer if you restored the behavior of RemoveStream when the PeerConnection is closed; that ...
3 years, 5 months ago (2017-07-24 18:37:21 UTC) #14
korniltsev
Done.
3 years, 5 months ago (2017-07-24 19:45:23 UTC) #15
Taylor Brandstetter
lgtm again. I'll try submitting it.
3 years, 5 months ago (2017-07-24 23:21:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2977493002/60001
3 years, 5 months ago (2017-07-24 23:21:43 UTC) #18
commit-bot: I haz the power
3 years, 5 months ago (2017-07-25 00:00:35 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/ec390b5dfbadb9972e4fafa36...

Powered by Google App Engine
This is Rietveld 408576698