Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2962713002: Fix inconsistent and incorrect Roboto Medium usage (Closed)

Created:
3 years, 5 months ago by gone
Modified:
3 years, 5 months ago
Reviewers:
Theresa
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix inconsistent and incorrect Roboto Medium usage A bunch of places are using sans-serif-medium, which doesn't exist before Lollipop. This means that text that is supposed to be bold ends up looking like all of the other text around it. * Replace users of sans-serif-medium with RobotoMediumStyle, which automatically flips between Roboto Medium and Roboto Bold as the platform allows. * Make everywhere that dynamically builds Typefaces/StyleSpans use a common function in UiUtils, which now references the font name and weight directly so that it's more obvious why it's needed. * ContextualSearchPromoView no longer tries to change its buttons' fonts, which buttons shouldn't do. * Remove the dead NativePageDialog. BUG=703968 Review-Url: https://codereview.chromium.org/2962713002 Cr-Commit-Position: refs/heads/master@{#482814} Committed: https://chromium.googlesource.com/chromium/src/+/0ecc34d1d8105c25cfd423cb21814fcb7e9bc324

Patch Set 1 #

Patch Set 2 : Fix inconsistent and incorrect Roboto Medium usage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -174 lines) Patch
M chrome/android/java/res/layout/account_signin_view.xml View 1 4 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/res/layout/contextual_search_peek_promo_text_view.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/contextual_search_promo_view.xml View 1 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/android/java/res/layout/dialog_with_titlebar.xml View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/android/java/res/layout/fre_data_reduction_proxy.xml View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/res/layout/new_tab_page_incognito.xml View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/res/layout/new_tab_page_incognito_md.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/res/layout/photo_picker_bitmap_view.xml View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/android/java/res/layout/snackbar.xml View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/res/values-v17/styles.xml View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/java/res/values-v21/styles.xml View 1 1 chunk +1 line, -2 lines 0 comments Download
D chrome/android/java/res/values-v21/values.xml View 1 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/android/java/res/values/values.xml View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java View 1 3 chunks +2 lines, -4 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageDialog.java View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/BillingAddressAdapter.java View 1 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java View 1 4 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java View 1 2 chunks +2 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/SyncErrorCardPreference.java View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -1 line 0 comments Download
M ui/android/java/src/org/chromium/ui/UiUtils.java View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
gone
Some screenshots are in the bug.
3 years, 5 months ago (2017-06-27 22:00:37 UTC) #3
Theresa
lgtm
3 years, 5 months ago (2017-06-27 22:48:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962713002/20001
3 years, 5 months ago (2017-06-27 22:58:49 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 00:21:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0ecc34d1d8105c25cfd423cb2181...

Powered by Google App Engine
This is Rietveld 408576698