chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java - Issue 2962713002: Fix inconsistent and incorrect Roboto Medium usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

Issue 2962713002: Fix inconsistent and incorrect Roboto Medium usage (Closed)

Patch Set: Fix inconsistent and incorrect Roboto Medium usage Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageDialog.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/ui/BillingAddressAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

index 8b1352d1da842c78d25e7bbc3a03d817374f55af..d117f6ca74d3222e7497e55bfbbbc8fdc02325e1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

@@ -9,7 +9,7 @@ import android.content.Intent;

import android.net.Uri;

import android.os.Build;

import android.text.SpannableString;

-import android.text.style.TypefaceSpan;

+import android.text.style.StyleSpan;

import android.view.View;

import org.chromium.base.ContextUtils;

@@ -74,7 +74,7 @@ public class GeolocationSnackbarController implements SnackbarController {

}

Uri searchUri = Uri.parse(TemplateUrlService.getInstance().getUrlForSearchQuery("foo"));

- TypefaceSpan robotoMediumSpan = new TypefaceSpan("sans-serif-medium");

+ StyleSpan robotoMediumSpan = new StyleSpan(R.style.RobotoMediumStyle);

String messageWithoutSpans = context.getResources().getString(

R.string.omnibox_geolocation_disclosure, "<b>" + searchUri.getHost() + "</b>");

SpannableString message = SpanApplier.applySpans(messageWithoutSpans,