Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2962453002: Move AX Role predicates into ax_role_properties.h. (Closed)

Created:
3 years, 6 months ago by dougt
Modified:
3 years, 5 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, aleventhal+watch_chromium.org, dtseng+watch_chromium.org, mac-reviews_chromium.org, je_julie, dmazzoni+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move AX Role predicates into ax_role_properties.h. In prep of moving more code from BrowserAccessibility to AXPlatformNode, there are a number of AXRole tests in the form of "Is this role a ____" hanging off of BrowserAccessibility and in BrowserAccessibilityManagerMac. What this CL does is adds a few more predicates in the UI:: namespace for this sort of testing. BUG=692087 Review-Url: https://codereview.chromium.org/2962453002 Cr-Commit-Position: refs/heads/master@{#482770} Committed: https://chromium.googlesource.com/chromium/src/+/48db56bc090cfeb1b2f1a556f0d5f21413627dd3

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -79 lines) Patch
M content/browser/accessibility/browser_accessibility.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 6 chunks +8 lines, -18 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_android.cc View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 2 11 chunks +12 lines, -10 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_com_win.cc View 1 5 chunks +7 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.mm View 6 chunks +6 lines, -35 lines 0 comments Download
M content/browser/accessibility/one_shot_accessibility_tree_search.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/accessibility/ax_role_properties.h View 1 chunk +12 lines, -0 lines 0 comments Download
M ui/accessibility/ax_role_properties.cc View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
dougt
3 years, 5 months ago (2017-06-27 00:05:30 UTC) #14
dmazzoni
lgtm
3 years, 5 months ago (2017-06-27 21:19:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962453002/40001
3 years, 5 months ago (2017-06-27 21:21:55 UTC) #17
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 22:50:06 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/48db56bc090cfeb1b2f1a556f0d5...

Powered by Google App Engine
This is Rietveld 408576698