color: Run GPU pixel tests with ColorCorrectRendering feature

color: Run GPU pixel tests with ColorCorrectRendering feature

This feature will be enabled by default soon. Make these tests run
using this feature so that they don't need to be rebaselined as the
feature is rolled out.

The --enable-features=ColorCorrectRendering flag will be removed once
the feature is on by default.

Also give the screenshot sync test a tolerance of 1 pixel because its
results sometimes vary by that much due to quantization error.

BUG=734255
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

[ccameron, 2017-06-25 17:22:06]

Description was changed from

==========
color: Run GPU pixel tests with ColorCorrectRendering feature

This feature will be enabled by default soon. Make these tests run
using this feature so that they don't need to be rebaselined as the
feature is rolled out.

The --enable-features=ColorCorrectRendering flag will be removed once
the feature is on by default.

Also give the screenshot sync test a tolerance of 1 pixel because its
results sometimes vary by that much due to quantization error.

BUG=734255
==========

to

==========
color: Run GPU pixel tests with ColorCorrectRendering feature

This feature will be enabled by default soon. Make these tests run
using this feature so that they don't need to be rebaselined as the
feature is rolled out.

The --enable-features=ColorCorrectRendering flag will be removed once
the feature is on by default.

Also give the screenshot sync test a tolerance of 1 pixel because its
results sometimes vary by that much due to quantization error.

BUG=734255
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2017-06-25 17:22:10]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-25 17:22:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-25 18:33:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-25 18:33:42]

Dry run: Try jobs failed on following builders:
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)

[ccameron, 2017-06-26 05:41:45]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 05:41:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 06:56:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 06:56:54]

Dry run: This issue passed the CQ dry run.

[ccameron, 2017-06-26 16:59:25]

ccameron@chromium.org changed reviewers:
+ kbr@chromium.org

[ccameron, 2017-06-26 16:59:26]

ptal -- this lets us avoid rebaseline-ing tests when we do enable the feature.
I'll remove the extra flag once I'm sure that the feature won't be turned back
off.

[Ken Russell (switch to Gerrit), 2017-06-26 17:35:25]

Please set:
git config --local gerrit.host true

in your workspace and start using gerrit :)

Let me know if you really want me to review this here or whether you're willing
to re-upload it in Gerrit.

[Ken Russell (switch to Gerrit), 2017-06-26 18:20:32]

lgtm fwiw.

[ccameron, 2017-06-26 18:27:40]

Moved over to https://chromium-review.googlesource.com/c/548818/