Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(193)

Issue 2959503002: Enable Polymer.Settings.useNativeShadow on the dashboard. (Closed)

Created:
2 years ago by benjhayden
Modified:
1 year, 9 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Enable Polymer.Settings.useNativeShadow on the dashboard. This is required in order to use tracing dom-modules on the dashboard. Several places throughout dashboard/elements and flot currently assume that they can querySelector() through dom-module boundaries. useNativeShadow breaks that, so those places need to do something else. http://www.baasic.com/2014/10/03/Using-jQuery-with-Web-components/ https://dev-benjhayden-c635dc64-dot-chromeperf.appspot.com

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -21 lines) Patch
M dashboard/dashboard/elements/autocomplete-box.html View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M dashboard/dashboard/elements/chart-container.html View 1 chunk +1 line, -2 lines 0 comments Download
M dashboard/dashboard/elements/chart-legend-tooltip-test.html View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M dashboard/dashboard/elements/chart-tooltip.html View 1 chunk +1 line, -0 lines 0 comments Download
M dashboard/dashboard/static/group_report.html View 1 chunk +1 line, -0 lines 0 comments Download
M dashboard/dashboard/static/report.html View 1 chunk +1 line, -0 lines 0 comments Download
M dashboard/dashboard/tests.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/flot/jquery.flot.js View 1 2 2 chunks +9 lines, -4 lines 0 comments Download
M third_party/flot/jquery.flot.min.js View 1 2 1 chunk +1 line, -8 lines 0 comments Download
M tracing/tracing/ui/base/polymer_preload.html View 1 2 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (7 generated)
benjhayden
Should I re-minify flot or is it ok to use the un-minified source?
2 years ago (2017-06-23 20:58:26 UTC) #3
eakuefner
2 years ago (2017-06-26 16:43:25 UTC) #4
lgtm

Please re-minify; there's precedent for doing this for other third_party
libraries with local modifications, e.g.
https://github.com/catapult-project/catapult/tree/master/third_party/chai

https://codereview.chromium.org/2959503002/diff/20001/tracing/tracing/ui/base...
File tracing/tracing/ui/base/polymer_preload.html (right):

https://codereview.chromium.org/2959503002/diff/20001/tracing/tracing/ui/base...
tracing/tracing/ui/base/polymer_preload.html:15: throw new Error('Cannot
proceed. Polymer already present.');
Can you update this error message? Polymer already present in shady DOM mode?

Powered by Google App Engine
This is Rietveld 408576698