Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2957743002:
MacViews: Fix VoiceOver feedback in editable fields. (Closed)
|
Created:
3 years, 6 months ago by tapted Modified:
3 years, 5 months ago Reviewers:
dmazzoni CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dougt+watch_chromium.org, aleventhal+watch_chromium.org, dtseng+watch_chromium.org, mac-reviews_chromium.org, dmazzoni+watch_chromium.org, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMacViews: Fix VoiceOver feedback in editable fields.
This requires some parameterized attributes to be supported.
BUG=657884
Review-Url: https://codereview.chromium.org/2957743002
Cr-Commit-Position: refs/heads/master@{#482502}
Committed: https://chromium.googlesource.com/chromium/src/+/c1c3d95e1a96f839511a8f6c52e65f1375c553e0
Patch Set 1 #Patch Set 2 : Add a test #
Total comments: 4
Patch Set 3 : kSelectableTextAttributes #
Messages
Total messages: 28 (23 generated)
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix VoiceOver feedback in editable field. This requires some parameterized attributes to be supported. BUG=657884 ========== to ========== Fix VoiceOver feedback in editable fields. This requires some parameterized attributes to be supported. BUG=657884 ==========
tapted@chromium.org changed reviewers: + dmazzoni@chromium.org
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:40001) has been deleted
Description was changed from ========== Fix VoiceOver feedback in editable fields. This requires some parameterized attributes to be supported. BUG=657884 ========== to ========== MacViews: Fix VoiceOver feedback in editable field. This requires some parameterized attributes to be supported. BUG=657884 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== MacViews: Fix VoiceOver feedback in editable field. This requires some parameterized attributes to be supported. BUG=657884 ========== to ========== MacViews: Fix VoiceOver feedback in editable fields. This requires some parameterized attributes to be supported. BUG=657884 ==========
Hi Dominic, please take a look. https://codereview.chromium.org/2957743002/diff/60001/ui/accessibility/platfo... File ui/accessibility/platform/ax_platform_node_mac.mm (right): https://codereview.chromium.org/2957743002/diff/60001/ui/accessibility/platfo... ui/accessibility/platform/ax_platform_node_mac.mm:675: return @0; This matches what's currently done for AXInsertionPointLineNumber for more complex stuff, we probably want to continue with that AXTextMarker refactoring, and share the same logic. https://codereview.chromium.org/2957743002/diff/60001/ui/accessibility/platfo... ui/accessibility/platform/ax_platform_node_mac.mm:706: NOTIMPLEMENTED(); This is the only one I've been able to hit with basic voiceover usage. returning nil just means it highlights the view bounds instead
lgtm https://codereview.chromium.org/2957743002/diff/60001/ui/accessibility/platfo... File ui/accessibility/platform/ax_platform_node_mac.mm (right): https://codereview.chromium.org/2957743002/diff/60001/ui/accessibility/platfo... ui/accessibility/platform/ax_platform_node_mac.mm:434: return kEditableTextAttributes; If we're exposing these for STATIC_TEXT, maybe a better name would be kSelectableTextAttributes?
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2957743002/diff/60001/ui/accessibility/platfo... File ui/accessibility/platform/ax_platform_node_mac.mm (right): https://codereview.chromium.org/2957743002/diff/60001/ui/accessibility/platfo... ui/accessibility/platform/ax_platform_node_mac.mm:434: return kEditableTextAttributes; On 2017/06/26 16:50:05, dmazzoni wrote: > If we're exposing these for STATIC_TEXT, maybe a better > name would be kSelectableTextAttributes? Good point! Done.
The CQ bit was unchecked by tapted@chromium.org
The CQ bit was checked by tapted@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/2957743002/#ps80001 (title: "kSelectableTextAttributes")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498525014309640,
"parent_rev": "47e7201e24fc08e37f0680f96b21bcbeff37230c", "commit_rev":
"b0945e079ea6b4a15137e6158451916816ea92f8"}
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498525014309640,
"parent_rev": "fc568e22f5b341c28a6671083bc56b30433985e6", "commit_rev":
"f538d9c1aefe9af91ea9b3ae533ac827fb46de3a"}
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498525014309640,
"parent_rev": "b3bf90c729cc252c1044be7cd5ab7b8a31ad17e6", "commit_rev":
"c1c3d95e1a96f839511a8f6c52e65f1375c553e0"}
Message was sent while issue was closed.
Description was changed from ========== MacViews: Fix VoiceOver feedback in editable fields. This requires some parameterized attributes to be supported. BUG=657884 ========== to ========== MacViews: Fix VoiceOver feedback in editable fields. This requires some parameterized attributes to be supported. BUG=657884 Review-Url: https://codereview.chromium.org/2957743002 Cr-Commit-Position: refs/heads/master@{#482502} Committed: https://chromium.googlesource.com/chromium/src/+/c1c3d95e1a96f839511a8f6c52e6... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as https://chromium.googlesource.com/chromium/src/+/c1c3d95e1a96f839511a8f6c52e6... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
