Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2957733002: Only call TextChanged on existing AXObjects. This avoids triggering the code which calls UpdateDist… (Closed)

Created:
3 years, 6 months ago by kochi
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Only call TextChanged on existing AXObjects. This avoids triggering the code which calls UpdateDistribution as part of creating a new AXObject, which was causing issues. This change should cause no behaviour changes, as in cases where an AXObject needs to be created for a text node, its parent will also have a ChildrenChanged notification fired on it, which will cause the appropriate updates to fire. Reverts https://codereview.chromium.org/2926713002/ as the code which causes UpdateDistribution to be called should never run with this change, so we don't need to check whether distribution is dirty any more. BUG=729229, 732200, 734348 Review-Url: https://codereview.chromium.org/2939933002 Cr-Original-Commit-Position: refs/heads/master@{#480792} Review-Url: https://codereview.chromium.org/2957733002 . Cr-Commit-Position: refs/branch-heads/3112@{#464} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/303e0e83015674dec5bf2fc1a5eafe2871e867ee

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
kochi
3 years, 6 months ago (2017-06-26 04:56:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
303e0e83015674dec5bf2fc1a5eafe2871e867ee.

Powered by Google App Engine
This is Rietveld 408576698