Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2955783002: [milo] fix tests on windows. (Closed)

Created:
3 years, 6 months ago by iannucci
Modified:
3 years, 5 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[milo] fix tests on windows. The symlink to the 'templates' folder doesn't work when running the tests on windows. Instead change the tests to load them from their true location directly. R=hinoka@chromium.org BUG= Review-Url: https://codereview.chromium.org/2955783002 Committed: https://github.com/luci/luci-go/commit/6e61686ebfb4647bbcf7b9916dcf2be390687959

Patch Set 1 #

Patch Set 2 : fix the other tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M milo/build_source/buildbot/html_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M milo/build_source/swarming/README.md View 1 1 chunk +0 lines, -2 lines 0 comments Download
M milo/build_source/swarming/html_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M milo/frontend/appengine/main.go View 1 chunk +4 lines, -2 lines 0 comments Download
M milo/frontend/main.go View 1 chunk +2 lines, -2 lines 0 comments Download
M milo/frontend/main_test.go View 1 chunk +1 line, -1 line 0 comments Download
D milo/frontend/templates View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
iannucci
3 years, 6 months ago (2017-06-25 20:12:02 UTC) #1
iannucci
(ptal+cq if lgty)
3 years, 5 months ago (2017-06-26 05:06:33 UTC) #10
Ryan Tseng
lgtm darn it, windows. Thanks
3 years, 5 months ago (2017-06-26 17:28:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955783002/20001
3 years, 5 months ago (2017-06-26 17:29:50 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 17:35:50 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/6e61686ebfb4647bbcf7b9916dcf2be390687959

Powered by Google App Engine
This is Rietveld 408576698