Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2955453002: improve fasta parser export declaration recovery (Closed)

Created:
3 years, 6 months ago by danrubel
Modified:
3 years, 4 months ago
Reviewers:
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

improve fasta parser export declaration recovery This change ensures that the export keyword in an export declaration is followed by a string literal expression by inserting a synthetic string literal if necessary. * gracefully recover from export declaration missing string literal * translate fasta codeExpectedString to analyzer EXPECTED_STRING_LITERAL * tweak insertTokenBefore to return the inserted token

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 6 chunks +17 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/token_stream_rewriter.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/front_end/messages.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/test/fasta/parser/token_stream_rewriter_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
danrubel
3 years, 4 months ago (2017-08-20 21:35:51 UTC) #1 
Description was changed from

==========
improve fasta parser export declaration recovery

This change ensures that the export keyword in an export declaration
is followed by a string literal expression by inserting a synthetic
string literal if necessary.

* gracefully recover from export declaration missing string literal
* translate fasta codeExpectedString to analyzer EXPECTED_STRING_LITERAL
* tweak insertTokenBefore to return the inserted token
==========

to

==========
improve fasta parser export declaration recovery

This change ensures that the export keyword in an export declaration
is followed by a string literal expression by inserting a synthetic
string literal if necessary.

* gracefully recover from export declaration missing string literal
* translate fasta codeExpectedString to analyzer EXPECTED_STRING_LITERAL
* tweak insertTokenBefore to return the inserted token
==========

Powered by Google App Engine
This is Rietveld 408576698