Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2954773003: Fix gn typo (Closed)

Created:
3 years, 6 months ago by brucedawson
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gn typo There is a missing space in one of the gn error messages. It currently says: This overwrites a previously-defined nonempty listwith another nonempty list. With this change it says: This overwrites a previously-defined nonempty list with another nonempty list. Now gn is perfect. R=brettw@chromium.org Review-Url: https://codereview.chromium.org/2954773003 Cr-Commit-Position: refs/heads/master@{#482203} Committed: https://chromium.googlesource.com/chromium/src/+/ce88977522c4fe591533766756a41c83d9225d32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/operators.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
brucedawson
Please review this sooper important gn cl.
3 years, 6 months ago (2017-06-23 23:38:10 UTC) #3
Dirk Pranke
lgtm
3 years, 6 months ago (2017-06-25 23:18:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954773003/1
3 years, 6 months ago (2017-06-26 06:18:08 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-26 06:36:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ce88977522c4fe591533766756a4...

Powered by Google App Engine
This is Rietveld 408576698