Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2954263003: Reland: Add support for $i18n{} localized strings to ios/web. (Closed)

Created:
3 years, 5 months ago by michaeldo
Modified:
3 years, 5 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Add support for $i18n{} localized strings to ios/web. The html templates used for chrome:// pages have been updated with new i18n support using $i18n{} style strings over the older i18n-content. BUG=734079 Review-Url: https://codereview.chromium.org/2952743002 Cr-Commit-Position: refs/heads/master@{#481966} Committed: https://chromium.googlesource.com/chromium/src/+/dcbf479ada2b075d70ab33dfa39b5a1891539b2a patch from issue 2952743002 at patchset 20001 (http://crrev.com/2952743002#ps20001) Review-Url: https://codereview.chromium.org/2954263003 Cr-Commit-Position: refs/heads/master@{#482429} Committed: https://chromium.googlesource.com/chromium/src/+/299faba705c67e03f6908c72dec4c4ffab09dfbe

Patch Set 1 #

Patch Set 2 : Add missing chrome://flags webUI template keys. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -6 lines) Patch
M ios/chrome/browser/ui/webui/flags_ui.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/web_ui_ios_data_source.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ios/web/webui/web_ui_ios_data_source_impl.h View 5 chunks +16 lines, -2 lines 0 comments Download
M ios/web/webui/web_ui_ios_data_source_impl.mm View 5 chunks +36 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
michaeldo
3 years, 5 months ago (2017-06-26 17:10:20 UTC) #2
Eugene But (OOO till 7-30)
lgtm, could you please wait until eg tests cycle through (I kicked off the tryjob)
3 years, 5 months ago (2017-06-26 17:21:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954263003/20001
3 years, 5 months ago (2017-06-26 21:45:40 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 22:03:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/299faba705c67e03f6908c72dec4...

Powered by Google App Engine
This is Rietveld 408576698