Break down Net.WebSocket.ErrorCodes by localhost

Break down Net.WebSocket.ErrorCodes by localhost

Add two new histograms, Net.WebSocket.ErrorCodes_Localhost and
Net.WebSocket.ErrorCodes_NotLocalhost, to split error codes by whether or not
the URL refers to localhost.

This is intended to determine what errors are caused by connections to
locally-running applications, and get better information about the errors that
other WebSocket servers have.

The matching is done by text, rather than by DNS lookup, so "localhost", 127.*
and ::1 will go into Net.WebSocket.ErrorCodes_Localhost but other host names
that happen to resolve to 127.0.0.1 will not.

Manually tested by looking at about:histograms.

BUG=

Review-Url: https://codereview.chromium.org/2950343002
Cr-Commit-Position: refs/heads/master@{#482197}
Committed: https://chromium.googlesource.com/chromium/src/+/56a7cdb2df5c350fbd1c97d0f35aada0d3d67b9b

[Adam Rice, 2017-06-22 15:02:42]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 15:02:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2017-06-22 15:04:02]

Description was changed from

==========
Break down Net.WebSocket.ErrorCodes by localhost

Add two new histograms, Net.WebSocket.ErrorCodes_Localhost and
Net.WebSocket.ErrorCodes_NotLocalhost, to split error codes by whether or not
the URL refers to localhost.

This is intended to determine what errors are caused by connections to
locally-running applications, and get better information about the errors that
other WebSocket servers have.

The matching is done by text, rather than by DNS lookup, so "localhost", 127.*
and ::1 will go into Net.WebSocket.ErrorCodes_Localhost but other host names
that happen to resolve to 127.0.0.1 will not.

BUG=
==========

to

==========
Break down Net.WebSocket.ErrorCodes by localhost

Add two new histograms, Net.WebSocket.ErrorCodes_Localhost and
Net.WebSocket.ErrorCodes_NotLocalhost, to split error codes by whether or not
the URL refers to localhost.

This is intended to determine what errors are caused by connections to
locally-running applications, and get better information about the errors that
other WebSocket servers have.

The matching is done by text, rather than by DNS lookup, so "localhost", 127.*
and ::1 will go into Net.WebSocket.ErrorCodes_Localhost but other host names
that happen to resolve to 127.0.0.1 will not.

Manually tested by looking at about:histograms.

BUG=
==========

[Adam Rice, 2017-06-22 15:04:14]

ricea@chromium.org changed reviewers:
+ tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2017-06-22 15:28:43]

lgtm!

[commit-bot: I haz the power, 2017-06-22 16:26:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 16:26:09]

Dry run: This issue passed the CQ dry run.

[Adam Rice, 2017-06-23 06:16:20]

ricea@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Adam Rice, 2017-06-23 06:16:20]

+asvitkine for histograms.xml.

[Alexei Svitkine (slow), 2017-06-23 18:47:38]

lgtm

[Adam Rice, 2017-06-26 03:58:14]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2017-06-26 03:58:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 05:10:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498449494347650, "parent_rev":
"5fd50a93c08586dc3adb03a6c2b0914c3378dc8b", "commit_rev":
"56a7cdb2df5c350fbd1c97d0f35aada0d3d67b9b"}

[commit-bot: I haz the power, 2017-06-26 05:10:27]

Description was changed from

==========
Break down Net.WebSocket.ErrorCodes by localhost

Add two new histograms, Net.WebSocket.ErrorCodes_Localhost and
Net.WebSocket.ErrorCodes_NotLocalhost, to split error codes by whether or not
the URL refers to localhost.

This is intended to determine what errors are caused by connections to
locally-running applications, and get better information about the errors that
other WebSocket servers have.

The matching is done by text, rather than by DNS lookup, so "localhost", 127.*
and ::1 will go into Net.WebSocket.ErrorCodes_Localhost but other host names
that happen to resolve to 127.0.0.1 will not.

Manually tested by looking at about:histograms.

BUG=
==========

to

==========
Break down Net.WebSocket.ErrorCodes by localhost

Add two new histograms, Net.WebSocket.ErrorCodes_Localhost and
Net.WebSocket.ErrorCodes_NotLocalhost, to split error codes by whether or not
the URL refers to localhost.

This is intended to determine what errors are caused by connections to
locally-running applications, and get better information about the errors that
other WebSocket servers have.

The matching is done by text, rather than by DNS lookup, so "localhost", 127.*
and ::1 will go into Net.WebSocket.ErrorCodes_Localhost but other host names
that happen to resolve to 127.0.0.1 will not.

Manually tested by looking at about:histograms.

BUG=

Review-Url: https://codereview.chromium.org/2950343002
Cr-Commit-Position: refs/heads/master@{#482197}
Committed:
https://chromium.googlesource.com/chromium/src/+/56a7cdb2df5c350fbd1c97d0f35a...
==========

[commit-bot: I haz the power, 2017-06-26 05:10:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/56a7cdb2df5c350fbd1c97d0f35a...