Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2948973002: [cr-action-menu] Constrain menu to viewport. (Closed)

Created:
3 years, 6 months ago by calamity
Modified:
3 years, 5 months ago
Reviewers:
dpapad
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[cr-action-menu] Constrain menu to viewport. This CL forces the action menu to align to the viewport after choosing an anchor direction. BUG=734984 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2948973002 Cr-Commit-Position: refs/heads/master@{#483938} Committed: https://chromium.googlesource.com/chromium/src/+/98e223c3c437db7740a771918a69869a91d79f91

Patch Set 1 #

Patch Set 2 : fix_closure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M chrome/test/data/webui/cr_elements/cr_action_menu_test.js View 1 4 chunks +12 lines, -10 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js View 1 1 chunk +10 lines, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
calamity
3 years, 6 months ago (2017-06-21 08:35:25 UTC) #3
dpapad
Thanks! LGTM
3 years, 6 months ago (2017-06-21 21:00:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948973002/1
3 years, 5 months ago (2017-07-03 01:56:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/9840)
3 years, 5 months ago (2017-07-03 02:26:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948973002/20001
3 years, 5 months ago (2017-07-03 03:40:37 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 04:00:07 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/98e223c3c437db7740a771918a69...

Powered by Google App Engine
This is Rietveld 408576698