Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2537)

Unified Diff: chrome/test/data/webui/cr_elements/cr_action_menu_test.js

Issue 2948973002: [cr-action-menu] Constrain menu to viewport. (Closed)
Patch Set: fix_closure Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/cr_elements/cr_action_menu_test.js
diff --git a/chrome/test/data/webui/cr_elements/cr_action_menu_test.js b/chrome/test/data/webui/cr_elements/cr_action_menu_test.js
index 5dc956f4ac487e70aba5707024483ddd6ce3472c..a62e53987833bafe2833bbe2f4adf480c27c12d0 100644
--- a/chrome/test/data/webui/cr_elements/cr_action_menu_test.js
+++ b/chrome/test/data/webui/cr_elements/cr_action_menu_test.js
@@ -215,8 +215,6 @@ suite('CrActionMenu', function() {
anchorAlignmentX: AnchorAlignment.CENTER,
anchorAlignmentY: AnchorAlignment.CENTER,
}));
- menuWidth = menu.offsetWidth;
- menuHeight = menu.offsetHeight;
assertEquals(`${120 - menuWidth / 2}px`, menu.style.left);
assertEquals(`${255 - menuHeight / 2}px`, menu.style.top);
menu.close();
@@ -226,8 +224,6 @@ suite('CrActionMenu', function() {
anchorAlignmentX: AnchorAlignment.BEFORE_END,
anchorAlignmentY: AnchorAlignment.BEFORE_END,
}));
- menuWidth = menu.offsetWidth;
- menuHeight = menu.offsetHeight;
assertEquals(`${140 - menuWidth}px`, menu.style.left);
assertEquals(`${260 - menuHeight}px`, menu.style.top);
menu.close();
@@ -239,8 +235,6 @@ suite('CrActionMenu', function() {
left: 0,
top: 0,
}));
- menuWidth = menu.offsetWidth;
- menuHeight = menu.offsetHeight;
assertEquals(`0px`, menu.style.left);
assertEquals(`0px`, menu.style.top);
menu.close();
@@ -253,17 +247,25 @@ suite('CrActionMenu', function() {
maxX: 1000,
maxY: 2000,
});
- menuWidth = menu.offsetWidth;
- menuHeight = menu.offsetHeight;
assertEquals(`${1000 - menuWidth}px`, menu.style.left);
assertEquals(`${2000 - menuHeight}px`, menu.style.top);
menu.close();
+ // If the viewport can't fit the menu, align the menu to the viewport.
+ menu.showAtPosition({
+ left: menuWidth - 5,
+ top: 0,
+ width: 0,
+ height: 0,
+ maxX: menuWidth * 2 - 10,
+ });
+ assertEquals(`${menuWidth - 10}px`, menu.style.left);
+ assertEquals(`0px`, menu.style.top);
+ menu.close();
+
// Alignment is reversed in RTL.
document.body.style.direction = 'rtl';
menu.showAtPosition(config);
- menuWidth = menu.offsetWidth;
- menuHeight = menu.offsetHeight;
assertTrue(menu.open);
assertEquals(140 - menuWidth, menu.offsetLeft);
assertEquals('250px', menu.style.top);
« no previous file with comments | « no previous file | ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698