Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2947103002: Expose getAnimations as function on Document (Closed)

Created:
3 years, 6 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose getAnimations as function on Document The document-level getAnimations function was previously defined on AnimationTimeline, requiring callers to specify document.timeline.getAnimations(). The Web Animations spec exposes this function on Document directly: document.getAnimations(). This patch moves the function to the appropriate place. Spec link: http://w3c.github.io/web-animations/#extensions-to-the-document-interface BUG=624639 Review-Url: https://codereview.chromium.org/2947103002 Cr-Commit-Position: refs/heads/master@{#482188} Committed: https://chromium.googlesource.com/chromium/src/+/da913699c72d5f97405db96ddaa4040ed621a0bc

Patch Set 1 #

Patch Set 2 : Update another webexposed listing #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
M third_party/WebKit/LayoutTests/animations/get-css-players.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/lazy-detached-animation-stop.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/animations/lazy-detached-animation-stop-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/animations/multiple-same-name-css-animations.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/animations/resources/animation-test-helpers.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/transitions-replay.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Animatable/animate-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Document/getAnimations-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/transitions/interrupted-immediately.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/transitions/repeated-firing-background-color.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/transitions/webkit-clip-path-equality.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimeline.idl View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/DocumentAnimation.h View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/DocumentAnimation.idl View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 32 (19 generated)
suzyh_UTC10 (ex-contributor)
3 years, 6 months ago (2017-06-21 04:49:18 UTC) #2
alancutter (OOO until 2018)
lgtm
3 years, 6 months ago (2017-06-21 05:26:48 UTC) #6
Eric Willigers
lgtm
3 years, 6 months ago (2017-06-21 16:24:53 UTC) #9
suzyh_UTC10 (ex-contributor)
+foolip for */webexposed/
3 years, 6 months ago (2017-06-22 03:17:42 UTC) #11
foolip
lgtm
3 years, 6 months ago (2017-06-22 10:14:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947103002/20001
3 years, 6 months ago (2017-06-23 03:59:28 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/126674) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-06-23 04:01:43 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947103002/40001
3 years, 6 months ago (2017-06-23 04:13:42 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/295055)
3 years, 6 months ago (2017-06-23 04:27:59 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947103002/40001
3 years, 6 months ago (2017-06-23 05:09:17 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/295114)
3 years, 6 months ago (2017-06-23 05:28:15 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947103002/60001
3 years, 5 months ago (2017-06-26 00:42:45 UTC) #29
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 03:01:00 UTC) #32
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/da913699c72d5f97405db96ddaa4...

Powered by Google App Engine
This is Rietveld 408576698