Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 2941043004: Show number of hidden items in new-style list notification. (Closed)

Created:
3 years, 6 months ago by tetsui
Modified:
3 years, 5 months ago
Reviewers:
yoshiki, fukino
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Show number of hidden items in new-style list notification. Show number of hidden items on the right bottom of the new-style notification in both collapsed and expanded state. BUG=726244 TEST=manual, also tested in RTL language (Hebrew) Review-Url: https://codereview.chromium.org/2941043004 Cr-Commit-Position: refs/heads/master@{#482198} Committed: https://chromium.googlesource.com/chromium/src/+/4cf375029b9abf4be32a79fbd7798622e12e569e

Patch Set 1 #

Patch Set 2 : Fix number of items shown in the expanded view. #

Total comments: 4

Patch Set 3 : Make overflow indicator localized. #

Patch Set 4 : Rebase. #

Patch Set 5 : Fix layout problem and some nits. #

Total comments: 4

Patch Set 6 : Resolve review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -8 lines) Patch
M ui/message_center/message_center_style.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M ui/message_center/views/notification_view_md.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M ui/message_center/views/notification_view_md.cc View 1 2 3 4 5 5 chunks +70 lines, -6 lines 0 comments Download
M ui/strings/ui_strings.grd View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 37 (28 generated)
tetsui
PTAL. Thanks!
3 years, 6 months ago (2017-06-21 06:00:14 UTC) #12
yoshiki
Did you check the layout in RTL languages? https://codereview.chromium.org/2941043004/diff/20001/ui/message_center/views/notification_view_md.cc File ui/message_center/views/notification_view_md.cc (right): https://codereview.chromium.org/2941043004/diff/20001/ui/message_center/views/notification_view_md.cc#newcode108 ui/message_center/views/notification_view_md.cc:108: DISALLOW_COPY_AND_ASSIGN(ItemView); ...
3 years, 6 months ago (2017-06-21 07:32:12 UTC) #13
tetsui
I moved the indicator to the localized string and also fixed a layout problem. Verified ...
3 years, 6 months ago (2017-06-22 07:25:23 UTC) #21
fukino
lgtm with a nit https://codereview.chromium.org/2941043004/diff/80001/ui/message_center/views/notification_view_md.cc File ui/message_center/views/notification_view_md.cc (right): https://codereview.chromium.org/2941043004/diff/80001/ui/message_center/views/notification_view_md.cc#newcode112 ui/message_center/views/notification_view_md.cc:112: class LayoutManager : public views::FillLayout ...
3 years, 5 months ago (2017-06-26 04:00:13 UTC) #28
fukino
https://codereview.chromium.org/2941043004/diff/80001/ui/message_center/views/notification_view_md.cc File ui/message_center/views/notification_view_md.cc (right): https://codereview.chromium.org/2941043004/diff/80001/ui/message_center/views/notification_view_md.cc#newcode579 ui/message_center/views/notification_view_md.cc:579: ItemView* item_view = new ItemView(items[i], items.size() - i - ...
3 years, 5 months ago (2017-06-26 04:18:38 UTC) #29
yoshiki
lgtm
3 years, 5 months ago (2017-06-26 05:00:17 UTC) #30
tetsui
Thank you! https://codereview.chromium.org/2941043004/diff/80001/ui/message_center/views/notification_view_md.cc File ui/message_center/views/notification_view_md.cc (right): https://codereview.chromium.org/2941043004/diff/80001/ui/message_center/views/notification_view_md.cc#newcode112 ui/message_center/views/notification_view_md.cc:112: class LayoutManager : public views::FillLayout { On ...
3 years, 5 months ago (2017-06-26 05:10:46 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941043004/100001
3 years, 5 months ago (2017-06-26 05:10:57 UTC) #34
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 06:12:58 UTC) #37
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/4cf375029b9abf4be32a79fbd779...

Powered by Google App Engine
This is Rietveld 408576698