Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 294033007: [Metrics] Merge MetricsService and MetricsServiceBase classes. (Closed)

Created:
6 years, 7 months ago by Ilya Sherman
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, blundell
Visibility:
Public.

Description

[Metrics] Merge MetricsService and MetricsServiceBase classes. BUG=374200 TEST=compiles R=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272247

Patch Set 1 #

Total comments: 2

Patch Set 2 : Restore OWNERS file #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -138 lines) Patch
M chrome/browser/metrics/metrics_service.h View 1 2 3 8 chunks +35 lines, -5 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 3 5 chunks +46 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_service_unittest.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/common/metrics/metrics_service_base.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/common/metrics/metrics_service_base.cc View 1 chunk +0 lines, -63 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Ilya Sherman
Alexei, this leaves the //chrome/common/metrics/ directory empty except for variations files. WDYT of renaming the ...
6 years, 7 months ago (2014-05-21 12:58:05 UTC) #1
Alexei Svitkine (slow)
LGTM % comment https://chromiumcodereview.appspot.com/294033007/diff/1/chrome/common/metrics/OWNERS File chrome/common/metrics/OWNERS (left): https://chromiumcodereview.appspot.com/294033007/diff/1/chrome/common/metrics/OWNERS#oldcode5 chrome/common/metrics/OWNERS:5: mpearson@chromium.org There are still sub-directories here, ...
6 years, 7 months ago (2014-05-21 13:05:22 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-21 13:12:03 UTC) #3
Ilya Sherman
https://chromiumcodereview.appspot.com/294033007/diff/1/chrome/common/metrics/OWNERS File chrome/common/metrics/OWNERS (left): https://chromiumcodereview.appspot.com/294033007/diff/1/chrome/common/metrics/OWNERS#oldcode5 chrome/common/metrics/OWNERS:5: mpearson@chromium.org On 2014/05/21 13:05:23, Alexei Svitkine wrote: > There ...
6 years, 7 months ago (2014-05-21 13:14:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/294033007/20001
6 years, 7 months ago (2014-05-21 19:59:15 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 08:54:20 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 08:57:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9693)
6 years, 7 months ago (2014-05-22 08:57:05 UTC) #8
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-22 11:38:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/294033007/40001
6 years, 7 months ago (2014-05-22 11:40:13 UTC) #10
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-22 14:05:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/294033007/30007
6 years, 7 months ago (2014-05-22 14:07:56 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 18:29:15 UTC) #13
Message was sent while issue was closed.
Change committed as 272247

Powered by Google App Engine
This is Rietveld 408576698