Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: chrome/browser/metrics/metrics_service_unittest.cc

Issue 294033007: [Metrics] Merge MetricsService and MetricsServiceBase classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/metrics/metrics_service.cc ('k') | chrome/chrome_common.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/metrics_service.h" 5 #include "chrome/browser/metrics/metrics_service.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/threading/platform_thread.h" 10 #include "base/threading/platform_thread.h"
(...skipping 19 matching lines...) Expand all
30 30
31 using metrics::MetricsLogManager; 31 using metrics::MetricsLogManager;
32 32
33 class TestMetricsService : public MetricsService { 33 class TestMetricsService : public MetricsService {
34 public: 34 public:
35 TestMetricsService(metrics::MetricsStateManager* state_manager, 35 TestMetricsService(metrics::MetricsStateManager* state_manager,
36 metrics::MetricsServiceClient* client) 36 metrics::MetricsServiceClient* client)
37 : MetricsService(state_manager, client) {} 37 : MetricsService(state_manager, client) {}
38 virtual ~TestMetricsService() {} 38 virtual ~TestMetricsService() {}
39 39
40 MetricsLogManager* log_manager() { 40 using MetricsService::log_manager;
41 return &log_manager_;
42 }
43 41
44 private: 42 private:
45 DISALLOW_COPY_AND_ASSIGN(TestMetricsService); 43 DISALLOW_COPY_AND_ASSIGN(TestMetricsService);
46 }; 44 };
47 45
48 #if defined(OS_CHROMEOS) 46 #if defined(OS_CHROMEOS)
49 class TestMetricsLogChromeOS : public MetricsLogChromeOS { 47 class TestMetricsLogChromeOS : public MetricsLogChromeOS {
50 public: 48 public:
51 explicit TestMetricsLogChromeOS( 49 explicit TestMetricsLogChromeOS(
52 metrics::ChromeUserMetricsExtension* uma_proto) 50 metrics::ChromeUserMetricsExtension* uma_proto)
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 367
370 service.RemoveObserver(&observer1); 368 service.RemoveObserver(&observer1);
371 369
372 service.OpenNewLog(); 370 service.OpenNewLog();
373 EXPECT_EQ(2, observer1.observed()); 371 EXPECT_EQ(2, observer1.observed());
374 EXPECT_EQ(2, observer2.observed()); 372 EXPECT_EQ(2, observer2.observed());
375 service.log_manager_.FinishCurrentLog(); 373 service.log_manager_.FinishCurrentLog();
376 374
377 service.RemoveObserver(&observer2); 375 service.RemoveObserver(&observer2);
378 } 376 }
OLDNEW
« no previous file with comments | « chrome/browser/metrics/metrics_service.cc ('k') | chrome/chrome_common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698