Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 291173009: SandboxIPCProcess: make shutdown mechanism explicit. (Closed)

Created:
6 years, 7 months ago by Jorge Lucangeli Obes
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

SandboxIPCProcess: make shutdown mechanism explicit. In order to move SandboxIPCProcess into a thread, we need a mechanism to make that thread exit. BUG=322185 TEST=content_shell loads webpages, browser shuts down correctly. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M content/browser/renderer_host/render_sandbox_host_linux.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_sandbox_host_linux.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/sandbox_ipc_linux.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jorge Lucangeli Obes
This supersedes https://chromiumcodereview.appspot.com/270983002/, using |lifeline_fd| explicitly to signal SandboxIPCProcess to exit. Removing '_exit(0)' from SandboxIPCProcess::Run() ...
6 years, 7 months ago (2014-05-21 23:51:14 UTC) #1
piman
lgtm
6 years, 7 months ago (2014-05-22 00:13:30 UTC) #2
Jorge Lucangeli Obes
+Matthew. Do you mind taking a look instead of Julien? He's probably swamped.
6 years, 7 months ago (2014-05-22 18:11:26 UTC) #3
mdempsky
lgtm
6 years, 7 months ago (2014-05-22 18:13:44 UTC) #4
Jorge Lucangeli Obes
The CQ bit was checked by jorgelo@chromium.org
6 years, 7 months ago (2014-05-22 18:14:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/291173009/1
6 years, 7 months ago (2014-05-22 18:18:57 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 22:42:04 UTC) #7
Message was sent while issue was closed.
Change committed as 272350

Powered by Google App Engine
This is Rietveld 408576698