Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Unified Diff: content/browser/renderer_host/sandbox_ipc_linux.cc

Issue 291173009: SandboxIPCProcess: make shutdown mechanism explicit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_sandbox_host_linux.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/sandbox_ipc_linux.cc
diff --git a/content/browser/renderer_host/sandbox_ipc_linux.cc b/content/browser/renderer_host/sandbox_ipc_linux.cc
index f156e30b60584cf77ccfb27a1464727614b2df16..7bcccc923b0a440bf00a5307cda774e7ef6193e8 100644
--- a/content/browser/renderer_host/sandbox_ipc_linux.cc
+++ b/content/browser/renderer_host/sandbox_ipc_linux.cc
@@ -169,15 +169,18 @@ void SandboxIPCProcess::Run() {
failed_polls = 0;
+ // The browser process will close the other end of this pipe on shutdown,
+ // so we should exit.
if (pfds[0].revents) {
- // our parent died so we should too.
- _exit(0);
+ break;
}
if (pfds[1].revents) {
HandleRequestFromRenderer(browser_socket_);
}
}
+
+ VLOG(1) << "SandboxIPCProcess stopping.";
}
void SandboxIPCProcess::HandleRequestFromRenderer(int fd) {
« no previous file with comments | « content/browser/renderer_host/render_sandbox_host_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698