Test for OscillatorNode.type=.

runtime/vm/dart_api_impl.cc

Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index 21cbd89ddd487aeb9b3b721cd8baea02d0b63951..0eff97cecbf22e456798769baa7f3165735837ab 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -264,6 +264,9 @@ bool Api::StringGetPeerHelper(Dart_NativeArguments args,
   NoGCScope no_gc_scope;
   NativeArguments* arguments = reinterpret_cast<NativeArguments*>(args);
   RawObject* raw_obj = arguments->NativeArgAt(arg_index);
+  if (!raw_obj->IsHeapObject()) {
+    return false;
+  }

[siva, 2013/10/22 00:08:53]

Why this is needed?

[rmacnak, 2013/10/22 00:28:21]

The assert in RawObject::GetClassId will fail when given a Smi.

Maybe we should be using an Object handle here instead, which does handle Smis.

[siva, 2013/10/22 18:26:49]

The function is supposed to be called only from
Dart_GetNativeStringArgument which expects a string object. Not
sure how a Smi was passed in, do we have a bug in the bindings code somewhere?

On 2013/10/22 00:28:21, Ryan Macnak wrote:

[rmacnak, 2013/10/22 18:54:13]

DartUtilities::dartToString and its callers do not check the argument's type.

Dart_GetNativeStringArgument calls StringGetPeerHelper before checking the
argument is a String.

For all non-String, heap objects, StringGetPeerHelper would answer false and
Dart_GetNativeStringArgument would fall through and generate an error handle.
Now we fall through for immediate objects as well.

   intptr_t cid = raw_obj->GetClassId();
   if (cid == kExternalOneByteStringCid) {
     RawExternalOneByteString* raw_string =