Test for OscillatorNode.type=.

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 
 #include "platform/assert.h"
 #include "vm/bigint_operations.h"
@@ skipping 246 matching lines @@
   null_handle_ = Api::InitNewHandle(isolate, Object::null());
 }
 
 
 bool Api::StringGetPeerHelper(Dart_NativeArguments args,
                               int arg_index,
                               void** peer) {
   NoGCScope no_gc_scope;
   NativeArguments* arguments = reinterpret_cast<NativeArguments*>(args);
   RawObject* raw_obj = arguments->NativeArgAt(arg_index);
+  if (!raw_obj->IsHeapObject()) {
+    return false;
+  }

[siva, 2013/10/22 00:08:53]

Why this is needed?

[rmacnak, 2013/10/22 00:28:21]

The assert in RawObject::GetClassId will fail when given a Smi.

Maybe we should be using an Object handle here instead, which does handle Smis.

[siva, 2013/10/22 18:26:49]

The function is supposed to be called only from
Dart_GetNativeStringArgument which expects a string object. Not
sure how a Smi was passed in, do we have a bug in the bindings code somewhere?

On 2013/10/22 00:28:21, Ryan Macnak wrote:

[rmacnak, 2013/10/22 18:54:13]

DartUtilities::dartToString and its callers do not check the argument's type.

Dart_GetNativeStringArgument calls StringGetPeerHelper before checking the
argument is a String.

For all non-String, heap objects, StringGetPeerHelper would answer false and
Dart_GetNativeStringArgument would fall through and generate an error handle.
Now we fall through for immediate objects as well.

   intptr_t cid = raw_obj->GetClassId();
   if (cid == kExternalOneByteStringCid) {
     RawExternalOneByteString* raw_string =
         reinterpret_cast<RawExternalOneByteString*>(raw_obj)->ptr();
     ExternalStringData<uint8_t>* data = raw_string->external_data_;
     *peer = data->peer();
     return true;
   }
   if (cid == kOneByteStringCid || cid == kTwoByteStringCid) {
     Isolate* isolate = arguments->isolate();
@@ skipping 4125 matching lines @@
   }
   {
     NoGCScope no_gc;
     RawObject* raw_obj = obj.raw();
     isolate->heap()->SetPeer(raw_obj, peer);
   }
   return Api::Success();
 }
 
 }  // namespace dart