Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2893063002: [WebUI] move polymer.html to first import (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by dschuyler
Modified:
1 week, 3 days ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dbeam+watch-downloads_chromium.org, David Trainor-ping if over 24h, jam, michaelpg+watch-md-ui_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebUI] move polymer.html to first import This Cl moves the imports of polymer.html to the top of the file so that polymer.html is imported before other files. This is an exception to the normal alphabetical order of imports. A blank line is added under this first import to visually separate it from the rest of the imports, since it's special. This ensures that custom elements can be configured according to polymer_config.js, which has to be loaded before any Polymer code. (code health) BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2893063002 Cr-Commit-Position: refs/heads/master@{#473390} Committed: https://chromium.googlesource.com/chromium/src/+/bd5768e5f739762df9dbb9201f9aac7c89e0625d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M chrome/browser/resources/md_bookmarks/app.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/command_manager.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/edit_dialog.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/folder_node.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/icons.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/item.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/list.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/router.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/toolbar.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/icons.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/manager.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-bookmarks-content/viewer-bookmarks-content.html View 1 chunk +1 line, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 14 (10 generated)
dschuyler
This change was done by hand rather than script, fyi.
1 week, 3 days ago (2017-05-19 18:55:08 UTC) #5
dpapad
LGTM. Perhaps rename [Polymer] to [WebUI] in the CL description?
1 week, 3 days ago (2017-05-19 18:59:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893063002/1
1 week, 3 days ago (2017-05-19 22:48:50 UTC) #11
commit-bot: I haz the power
1 week, 3 days ago (2017-05-20 00:08:33 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bd5768e5f739762df9dbb9201f9a...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06