Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1821)

Unified Diff: chrome/browser/policy/cloud/cloud_policy_invalidator.h

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)
Patch Set: simplify type checking Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/cloud/cloud_policy_invalidator.h
diff --git a/chrome/browser/policy/cloud/cloud_policy_invalidator.h b/chrome/browser/policy/cloud/cloud_policy_invalidator.h
index a2e3be8ec5ce3bbc28a4c44103a4b422d502def3..76db79a34843d9515084693a92797f516a721c6b 100644
--- a/chrome/browser/policy/cloud/cloud_policy_invalidator.h
+++ b/chrome/browser/policy/cloud/cloud_policy_invalidator.h
@@ -21,6 +21,7 @@
#include "components/invalidation/public/invalidation_handler.h"
#include "components/policy/core/common/cloud/cloud_policy_core.h"
#include "components/policy/core/common/cloud/cloud_policy_store.h"
+#include "components/policy/core/common/cloud/enterprise_metrics.h"
#include "components/policy/proto/device_management_backend.pb.h"
#include "google/cacheinvalidation/include/types.h"
@@ -156,11 +157,12 @@ class CloudPolicyInvalidator : public syncer::InvalidationHandler,
// Get the kMetricPolicyRefresh histogram metric which should be incremented
// when a policy is stored.
- int GetPolicyRefreshMetric(bool policy_changed);
+ MetricPolicyRefresh GetPolicyRefreshMetric(bool policy_changed);
// Get the kMetricPolicyInvalidations histogram metric which should be
// incremented when an invalidation is received.
- int GetInvalidationMetric(bool is_missing_payload, bool is_expired);
+ PolicyInvalidationType GetInvalidationMetric(bool is_missing_payload,
+ bool is_expired);
// Determine if invalidations have been enabled longer than the grace period.
bool GetInvalidationsEnabled();

Powered by Google App Engine
This is Rietveld 408576698