chrome/browser/notifications/message_center_stats_collector.cc - Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/message_center_stats_collector.cc

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)

Patch Set: simplify type checking Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/message_center_stats_collector.cc

diff --git a/chrome/browser/notifications/message_center_stats_collector.cc b/chrome/browser/notifications/message_center_stats_collector.cc

index 0f336eacd84dcd4caaabc30f9e3bcffb276fd94a..24b4e857bb45ba14a6a46a1d2c55aa899f57453b 100644

--- a/chrome/browser/notifications/message_center_stats_collector.cc

+++ b/chrome/browser/notifications/message_center_stats_collector.cc

@@ -40,7 +40,7 @@ void MessageCenterStatsCollector::NotificationStats::RecordAggregateStats() {

if (!actions_[i])

continue;

UMA_HISTOGRAM_ENUMERATION("Notifications.PerNotificationActions",

- i,

+ static_cast<NotificationActionType>(i),

NOTIFICATION_ACTION_COUNT);

}