Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

components/payments/core/journey_logger.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/payments/core/journey_logger.h"
 
 #include <algorithm>
 
 #include "base/metrics/histogram_functions.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 185 matching lines @@
     UMA_HISTOGRAM_BOOLEAN("PaymentRequest.CheckoutFunnel.SkippedShow", true);
 }
 
 void JourneyLogger::RecordPaymentMethodMetric() {
   base::UmaHistogramEnumeration("PaymentRequest.SelectedPaymentMethod",
                                 payment_method_, SELECTED_PAYMENT_METHOD_MAX);
 }
 
 void JourneyLogger::RecordRequestedInformationMetrics() {
   DCHECK(requested_information_ != REQUESTED_INFORMATION_MAX);
-  UMA_HISTOGRAM_ENUMERATION("PaymentRequest.RequestedInformation",
-                            requested_information_, REQUESTED_INFORMATION_MAX);
+  UMA_HISTOGRAM_ENUMERATION(
+      "PaymentRequest.RequestedInformation",
+      static_cast<RequestedInformation>(requested_information_),
+      REQUESTED_INFORMATION_MAX);
 }
 
 void JourneyLogger::RecordSectionSpecificStats(
     CompletionStatus completion_status) {
   // Record whether the user had suggestions for each requested information.
   bool user_had_all_requested_information = true;
 
   for (int i = 0; i < NUMBER_OF_SECTIONS; ++i) {
     std::string name_suffix = GetHistogramNameSuffix(i, completion_status);
 
@@ skipping 73 matching lines @@
   if (!was_can_make_payments_used_)
     return;
 
   int effect_on_show = 0;
   if (was_show_called_)
     effect_on_show |= CMP_EFFECT_ON_SHOW_DID_SHOW;
   if (could_make_payment_)
     effect_on_show |= CMP_EFFECT_ON_SHOW_COULD_MAKE_PAYMENT;
 
   UMA_HISTOGRAM_ENUMERATION("PaymentRequest.CanMakePayment.Used.EffectOnShow",
-                            effect_on_show, CMP_EFFECT_ON_SHOW_MAX);
+                            static_cast<CmpEffectOnShow>(effect_on_show),
+                            CMP_EFFECT_ON_SHOW_MAX);
 }
 
 void JourneyLogger::RecordCanMakePaymentEffectOnCompletion(
     CompletionStatus completion_status) {
   if (!was_show_called_)
     return;
 
   std::string histogram_name = "PaymentRequest.CanMakePayment.";
   if (!was_can_make_payments_used_) {
     histogram_name += "NotUsed.WithShowEffectOnCompletion";
@@ skipping 16 matching lines @@
   ukm_recorder_->UpdateSourceURL(source_id, url_);
   std::unique_ptr<ukm::UkmEntryBuilder> builder =
       ukm_recorder_->GetEntryBuilder(source_id,
                                      internal::kUKMCheckoutEventsEntryName);
   builder->AddMetric(internal::kUKMCompletionStatusMetricName,
                      completion_status);
   builder->AddMetric(internal::kUKMEventsMetricName, events_);
 }
 
 }  // namespace payments